Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 'disconnect' in Eip1193 provider must emit ProviderRpcError #6230

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #6003

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 640 KB 646 KB 6.17 KB 0.97%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 623 KB 629 KB 6.17 KB 0.99%
../lib/commonjs/index.d.ts 8.56 KB 8.56 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 811 bytes 811 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: decab4a
Status: ✅  Deploy successful!
Preview URL: https://bb7b4a36.web3-js-docs.pages.dev
Branch Preview URL: https://6003-disconnect-in-eip1193-p.web3-js-docs.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #6230 (bf985dc) into 4.x (ebd0c57) will increase coverage by 0.97%.
The diff coverage is 92.68%.

❗ Current head bf985dc differs from pull request most recent head decab4a. Consider uploading reports for the commit decab4a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6230      +/-   ##
==========================================
+ Coverage   87.62%   88.59%   +0.97%     
==========================================
  Files         197      198       +1     
  Lines        7601     7625      +24     
  Branches     2083     2092       +9     
==========================================
+ Hits         6660     6755      +95     
+ Misses        941      870      -71     
Flag Coverage Δ
UnitTests 88.59% <92.68%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@Muhammad-Altabba Muhammad-Altabba merged commit 51bc03d into 4.x Jul 12, 2023
31 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 6003-disconnect-in-eip1193-provider-must-emit-providerrpcerror branch July 12, 2023 18:44
This was referenced Aug 3, 2023
sanyu1225 pushed a commit to blocto/web3.js that referenced this pull request Aug 30, 2023
…3#6230)

* Add `EIP1193ProviderRpcError` and use it when provider `_onDisconnect`

* Update CHANGELOG.md for web3-errors

* add some unit tests for rpc errors

* add `genericRpcErrorMessageTemplate`  to `rpc_error_messages.ts`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'disconnect' in Eip1193 provider must emit ProviderRpcError
4 participants