remove symlinks #6189
Closed
remove symlinks #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6189 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 197 197
Lines 7557 7557
Branches 2060 2060
=======================================
Hits 6610 6610
Misses 947 947
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
| Latest commit: |
305d9d6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0a00a309.web3-js-docs.pages.dev |
| Branch Preview URL: | https://5075-symlinks.web3-js-docs.pages.dev |
|
@luu-alex have you tried building 4.x using: |
|
@jdevcs yes it works properly |
|
The windows build properly now, but it runs into a typescript compile issue |
luu-alex
requested review from
avkos,
jdevcs,
Muhammad-Altabba and
spacesailor24
as code owners
I know the time has already been invested in refactoring our use of symlinks, but it seems like solving this TS issue, keeping the symlinks and current repo config, and having Windows users use WSL would be a better approach. It's nice to have a single source of truth for these config files, and having each package have their own version of the files seem like an easy way for an update to get missed for a particular package |
|
@spacesailor24 i think thats fine, i'll close the pr + issue |
|
I am facing this issue on windows . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#5075
this PR addresses an issue with building errors from windows computers.
Symlinks paths are not supported the same way on windows/linux leading to an error when trying to build.
This PR replaces the symlink files with the actual file. As well I added a new script, it generates files based on the source template and target directory.
in this pr as well, theres some config and template clean up
The notable changes in this PR:
configdirectoryPlease include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.