fix: unnecessary array copy when pack encoding (#6553)

* fix: unnecessary array copy when pack encoding Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> * fix: remove unreachable code Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> * remove unsupported test fixture Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> --------- Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
web3 · Nov 20, 2023 · af91519 · af91519
1 parent 2c60685
commit af91519
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/web3-utils/CHANGELOG.md b/packages/web3-utils/CHANGELOG.md
@@ -176,3 +176,7 @@ Documentation:
 -   `SocketProvider` now contains public function `getPendingRequestQueueSize`, `getSentRequestsQueueSize` and `clearQueues` (#6479)
 -   Added `safeDisconnect` as a `SocketProvider` method to disconnect only when request queue size and send request queue size is 0 (#6479) 
 -   Add `isContractInitOptions` method (#6555)
+
+### Fixed
+
+-   Fix unecessary array copy when pack encoding (#6553)
diff --git a/packages/web3-utils/src/hash.ts b/packages/web3-utils/src/hash.ts
@@ -330,8 +330,7 @@ export const processSolidityEncodePackedArgs = (arg: Sha3Input): string => {
  * Encode packed arguments to a hexstring
  */
 export const encodePacked = (...values: Sha3Input[]): string => {
-	const args = Array.prototype.slice.call(values);
-	const hexArgs = args.map(processSolidityEncodePackedArgs);
+	const hexArgs = values.map(processSolidityEncodePackedArgs);
 	return `0x${hexArgs.join('').toLowerCase()}`;
 };