Fix <meta> post-insertion steps expectations
#45457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5410497
branch
from
6b7fd60
to
b7745de
Compare
See whatwg/html#10241 for the recommendation to change these test expectations to align with Chromium and WebKit's behavior. FWIW, I did try and change the processing of these kinds of meta tags in Chromium to use the insertion steps [1], and without any extra work at least, this caused a bunch of crashes [2]. So this change (changing the test expectations) is easier, and aligns with more browsers. [1]: https://crrev.com/c/5399060 [2]: https://crbug.com/330694762 R=nrosenthal@chromium.org Bug: 40150299, 330694762 Change-Id: I60f8ba556984bc1e8df4ba6e1dc375b1dfb7823d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410497 Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1281241}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5410497
branch
from
b7745de
to
5a793a9
Compare
wpt-pr-bot
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#10241 for the recommendation
to change these test expectations to align with Chromium and WebKit's
behavior.
FWIW, I did try and change the processing of these kinds of meta tags
in Chromium to use the insertion steps 1, and without any extra work
at least, this caused a bunch of crashes 2.
So this change (changing the test expectations) is easier, and aligns
with more browsers.
R=nrosenthal@chromium.org
Bug: 40150299, 330694762
Change-Id: I60f8ba556984bc1e8df4ba6e1dc375b1dfb7823d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410497
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1281241}