Streams: test promise resolution order of async iterator #44456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2024
domenic
approved these changes
Feb 14, 2024
|
I'm not sure why the test sometimes times out in Chrome. I don't have time to do further investigation today. |
MattiasBuelens
force-pushed
the
streams-async-iterator-promise-order
branch
from
c546cdc
to
545b43e
Compare
MattiasBuelens
force-pushed
the
streams-async-iterator-promise-order
branch
from
545b43e
to
4d1e4c9
Compare
MattiasBuelens
force-pushed
the
streams-async-iterator-promise-order
branch
from
4d1e4c9
to
1b055dc
Compare
|
Checks are finally green! Just needed to rebase a couple of times. 😛 |
domenic
pushed a commit
to whatwg/streams
that referenced
this pull request
Apr 24, 2024
Notably, this includes tests for promise resolution order of async iterators in the reference implementation. This requires updating webidl2js. See whatwg/webidl#1387, web-platform-tests/wpt#44456, and jsdom/webidl2js#269 for context.
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
May 13, 2024
…hod (#23642) See whatwg/webidl#1387 for context. There are new WPT tests for this change in web-platform-tests/wpt#44456. They pass on my local machine, but I'm not sure if I should update the WPT submodule for all of Deno as part of this PR? Fixes #22389 --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
May 16, 2024
…hod (#23642) See whatwg/webidl#1387 for context. There are new WPT tests for this change in web-platform-tests/wpt#44456. They pass on my local machine, but I'm not sure if I should update the WPT submodule for all of Deno as part of this PR? Fixes #22389 --------- Co-authored-by: Asher Gomez <ashersaupingomez@gmail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/webidl#1387