Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to disallow 3rd party origin subframe JS dialogs #27435

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 2, 2021

Test: Covered by WPT, except for alert (which can't be tested in WPT).

Bug: 1065085
Change-Id: I8a58be63014c7893ab864d3582516a9eddbf5e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645693
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851920}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@carlosjoan91
Copy link
Contributor

@web-platform-tests/wpt-core-team Re:wpt-chrome-dev-stability. Chrome is expected to fail this WPT since the feature is not still implemented in Chrome by default. But this is triggering the flakiness check due to it sometimes failing (due to an unexpected alert), and other times timing out (due to the alert remaining open presumably).
My guess is increasing the timeout would always result in a failure and get rid of the flakiness, but it is unclear to me how to do that, or what would be the best way to proceed here. (This is temporary regardless, as once the feature is enabled in Chrome, it will pass the test instead of flaking between timeout and error).

@domenic
Copy link
Member

domenic commented Feb 8, 2021

@carlosjoan91 you can add <meta timeout="long"> to the top to increase the timeout. However, if that doesn't work, or you think it's not a good idea for long-term maintenance, then we can just get @web-platform-tests/wpt-core-team to admin-merge this despite the temporary flakiness.

@stephenmcgruer
Copy link
Contributor

Ack; I suspect this is actually showing a bug with how we handle unexpectedly open alerts (possibly in webdriver). I don't think a long timeout would help.

We're happy to admin-merge this PR once the Chromium CL has landed.

Test: Covered by WPT, except for alert (which can't be tested in WPT).

Bug: 1065085
Change-Id: I8a58be63014c7893ab864d3582516a9eddbf5e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645693
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#851920}
@stephenmcgruer stephenmcgruer merged commit d328f4c into master Feb 8, 2021
@stephenmcgruer stephenmcgruer deleted the chromium-export-cl-2645693 branch February 8, 2021 23:58
@carlosjoan91
Copy link
Contributor

Thanks for merging! And yeah, having this in the current flaky between failing and timing out is not particularly terrible, since it will go back to reliably passing once the feature is enabled by default in Chromium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants