Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Module Scripts #596

Closed
2 of 3 tasks
dandclark opened this issue Oct 26, 2023 · 4 comments
Closed
2 of 3 tasks

JSON Module Scripts #596

dandclark opened this issue Oct 26, 2023 · 4 comments
Labels
focus-area-proposal Focus Area Proposal

Comments

@dandclark
Copy link
Contributor

dandclark commented Oct 26, 2023

Description

JSON modules (with import attributes) are a way to import JSON in JavaScript.

Note: Per discussion of the interop team this proposal is split off from #436 to be considered independently of CSS module scripts in proposal selection.
cc @o-t-w.

Specification

https://github.com/tc39/proposal-import-attributes
https://github.com/tc39/proposal-json-modules

Open Issues

whatwg/html#7233
There is an open PR that would close this issue.

Tests

https://wpt.fyi/results/html/semantics/scripting-1/the-script-element?label=master&label=experimental&aligned&q=%28import-attributes%20or%20json%29%20and%20not%20assertions

Current Implementations

  • Blink
  • Gecko
  • WebKit

Standards Positions

Safari Technology Preview supports import attributes and JSON modules.

Chrome Canary is currently updating the import attribute syntax from import assertions.

Browser bug reports

Gecko bug for import attributes.

Developer discussions

This Tweet has almost 900 likes https://x.com/mattpocockuk/status/1694679999117246640?s=20

Polls & Surveys

No response

Existing Usage

No response

Workarounds

No response

Accessibility Impact

No impact.

Privacy Impact

No impact.

Other

No response

@jensimmons
Copy link
Contributor

JSON module assertions is not standard, and should not be included in this proposal.

Seems their tests will be marked optional. They should not be included in Interop 2024.
web-platform-tests/wpt#42875

@dandclark
Copy link
Contributor Author

Looks to me like the test link https://wpt.fyi/results/html/semantics/scripting-1/the-script-element?label=master&label=experimental&aligned&q=%28import-attributes%20or%20json%29%20and%20not%20assertions in the proposal is already excluding those and including only the versions with the new with keyword, but we should double-check after the changes proposed in web-platform-tests/wpt#42875 land to make sure the right set of tests is still included.

@gsnedders
Copy link
Member

FYI:

% rg 'assert[^_]' html/semantics/scripting-1/the-script-element/import-attributes html/semantics/scripting-1/the-script-element/json-module
html/semantics/scripting-1/the-script-element/import-attributes/dynamic-import-with-attributes-argument.any.js
16:        import("./export-hello.js", { assert: { type: "notARealType"} } ),

(There's other matches that aren't relevant.)

nicolo-ribaudo added a commit to nicolo-ribaudo/wpt that referenced this issue Nov 2, 2023
Caught by @gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
Ms2ger pushed a commit to web-platform-tests/wpt that referenced this issue Nov 17, 2023
Caught by @gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 22, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by @gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 22, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by @gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 24, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by @gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this issue Nov 24, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by @gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914

UltraBlame original commit: 5288385a6b6c0ce1db2f7c5bacc43e79c9743db9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914

UltraBlame original commit: 5288385a6b6c0ce1db2f7c5bacc43e79c9743db9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2023
…utes tests, a=testonly

Automatic update from web-platform-tests
Replace missed `assert` in import attributes tests

Caught by gsnedders (web-platform-tests/interop#596 (comment))

I'm not sure how it's possible I replaced just two of the three `assert`s in this file 🙃
--

wpt-commits: 6593bded6f610c2616e53075d42b51d9566a7f54
wpt-pr: 42914

UltraBlame original commit: 5288385a6b6c0ce1db2f7c5bacc43e79c9743db9
@nairnandu
Copy link
Contributor

Thank you for proposing JSON Module Scripts for inclusion in Interop 2024.

We wanted to let you know that this proposal was not selected to be part of Interop 2024. This is because we got many more proposals than we could include in this year's project. Note that individual vendors may nevertheless choose to advance work in this area during the forthcoming year. We would welcome this proposal being resubmitted again next year, if necessary.

For an overview of our process, see proposal selection. Thank you again for contributing to Interop 2024!

Posted on behalf of the Interop team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus-area-proposal Focus Area Proposal
Projects
Status: Done
Development

No branches or pull requests

4 participants