Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loader intermediate data should be overridden between loaders #7846

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: loader intermediate data should be overridden between loaders #7846

merged 2 commits into from
Sep 10, 2024

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Sep 10, 2024 •
edited
Loading

Summary

closes #7819
closes #7798

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Sep 10, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit b0c674a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66dfc2e90624960008c02230
😎 Deploy Preview https://deploy-preview-7846--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 10, 2024
chenjiahan
chenjiahan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

chenjiahan
chenjiahan reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also make the documentation more clear? I think the webpack documentation does not not provide an accurate description of the meta lifecycle.

https://rspack.dev/api/loader-api/context

@h-a-n-a h-a-n-a merged commit f152903 into main Sep 10, 2024
35 checks passed
@h-a-n-a h-a-n-a deleted the fix/loader-additional-data branch September 10, 2024 08:03
@h-a-n-a h-a-n-a mentioned this pull request Sep 10, 2024
Merged
2 tasks
@chenjiahan chenjiahan mentioned this pull request Sep 12, 2024
Closed
@fi3ework fi3ework mentioned this pull request Sep 12, 2024
Merged
2 tasks
@chenjiahan chenjiahan mentioned this pull request Sep 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
2 participants
@h-a-n-a @chenjiahan