Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deep merge module resolve options #7470

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix: deep merge module resolve options #7470

merged 2 commits into from
Aug 6, 2024

Conversation

ahabhgk
Copy link
Collaborator

@ahabhgk ahabhgk commented Aug 6, 2024

Summary

  • fix deep merge module resolve options
  • optimize perf with ModuleRuleEffect, we only need ModuleRuleEffect when calculate_module_xxx, and this will be helpful for debugging dbg!(rules)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk enabled auto-merge (squash) August 6, 2024 09:46
@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Aug 6, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Aug 6, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 6, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5e12e34
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b1f0e1c55e1b00086fb164

@ahabhgk ahabhgk merged commit c0ea8ac into main Aug 6, 2024
33 checks passed
@ahabhgk ahabhgk deleted the fix-deep-merge-resolve branch August 6, 2024 09:53
@chenjiahan chenjiahan mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyMind SyMind SyMind approved these changes

Assignees

@ahabhgk ahabhgk

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahabhgk @SyMind