chore(infra/biome): enable noParameterAssign #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
chenjiahan
reviewed
Aug 5, 2024
shulaoda
force-pushed
the
chore/biome-enable-noParameterAssign
branch
from
a37662d
to
aa14dcf
Compare
SoonIter
reviewed
Aug 5, 2024
|
Please let me know when your review is completed, and I will update the branch all at once. @SoonIter |
SoonIter
reviewed
Aug 5, 2024
done, I like |
shulaoda
force-pushed
the
chore/biome-enable-noParameterAssign
branch
from
d686b72
to
857cc97
Compare
SoonIter
approved these changes
Aug 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #7182
Checklist