Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency sass-loader to v16 #7370

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 30, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sass-loader 14.2.1 -> 16.0.0 age adoption passing confidence

Release Notes

webpack-contrib/sass-loader (sass-loader)

v16.0.0

Compare Source

⚠ BREAKING CHANGES
  • use modern Sass JS API by default for sass and sass-embedded

[!WARNING]

The sass options are different for the legacy (before) and modern APIs. Please look at docs how to migrate to the modern options.
Legacy options - https://sass-lang.com/documentation/js-api/interfaces/legacystringoptions/
Modern options - https://sass-lang.com/documentation/js-api/interfaces/options/

To return to the previous logic use:

module.exports = {
  module: {
    rules: [
      {
        test: /\.s[ac]ss$/i,
        use: [
          "style-loader",
          "css-loader",
          {
            loader: "sass-loader",
            options: {
              api: "legacy",
              // Your options
            },
          },
        ],
      },
    ],
  },
};
Features
  • use modern Sass JS API by default for sass and sass-embedded (10be1ba)

v15.0.0

Compare Source

⚠ BREAKING CHANGES
  • prefer sass-embedded over sass by default (#​1211)
Features
14.2.1 (2024-04-16)
Bug Fixes

Configuration

📅 Schedule: Branch creation - "before 8am on wednesday" in timezone Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 0c2002e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66b06e5468ae14000841ff4e

chenjiahan
chenjiahan previously approved these changes Aug 3, 2024
Copy link
Contributor Author

renovate bot commented Aug 3, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@chenjiahan chenjiahan enabled auto-merge (squash) August 3, 2024 02:20
loader: "sass-loader"
loader: "sass-loader",
options: {
// use legacy API to generate source maps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added api: 'legacy' here because the modern Sass API disabled sourceMapIncludeSources: true by default, see webpack-contrib/sass-loader#1222

@chenjiahan chenjiahan merged commit 12d58a9 into main Aug 5, 2024
28 checks passed
@chenjiahan chenjiahan deleted the renovate/sass-loader-16.x branch August 5, 2024 06:34
@chenjiahan chenjiahan mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant