Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: align optimization.moduleIds and optimization.chunkIds when mode=none #6956

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix!: align optimization.moduleIds and optimization.chunkIds when mode=none #6956

merged 1 commit into from
Jun 27, 2024

Conversation

LingyuCoder
Copy link
Collaborator

Summary

  • use natural as optimization.moduleIds and optimization.chunkIds default value when mode is none

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jun 27, 2024
@LingyuCoder
Copy link
Collaborator Author

cc @colinaaa

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bd1981e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667d2e9bd45179000841491e

@chenjiahan chenjiahan enabled auto-merge (squash) June 27, 2024 09:24
@chenjiahan chenjiahan merged commit a30bfdb into main Jun 27, 2024
34 checks passed
@chenjiahan chenjiahan deleted the fix/align-module-chunk-ids branch June 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@SyMind SyMind Awaiting requested review from SyMind

Assignees

@LingyuCoder LingyuCoder

Labels
release: breaking change release: breaking change related release(mr only) release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @chenjiahan