fix!: change default value of css to false, align with webpack #6910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
LingyuCoder
previously approved these changes
Jun 25, 2024
JSerFeng
force-pushed
the
refactor/some-defaults
branch
3 times, most recently
from
ccbc07f
to
a45c1e9
Compare
SyMind
reviewed
Jun 25, 2024
JSerFeng
force-pushed
the
refactor/some-defaults
branch
2 times, most recently
from
fa971ca
to
c546b95
Compare
|
we should update the document about experiments.css usage at the same time |
|
this title is misleading, it should be feat or fix and the description should contain breaking change notice |
JSerFeng
changed the title
github-actions
bot
added
the
release: bug fix
ahabhgk
changed the title
JSerFeng
changed the title
JSerFeng
force-pushed
the
refactor/some-defaults
branch
2 times, most recently
from
cce5486
to
1310a99
Compare
JSerFeng
force-pushed
the
refactor/some-defaults
branch
from
1310a99
to
4fff03a
Compare
JSerFeng
commented
Jun 26, 2024
SyMind
approved these changes
Jun 26, 2024
I'll add docs asap |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Change
Align default value of css with webpack, the default value is false now.
Checklist