Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: code-splitting should not regenerate chunk #6749

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

JSerFeng
Copy link
Collaborator

@JSerFeng JSerFeng commented Jun 6, 2024

Summary

Every time when iteratoring a block, there will be a new chunk created, though the chunk is not used, but it will stay in memory

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 6, 2024
Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit fdfff21
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6661b266da11e00008b0da0b
😎 Deploy Preview https://deploy-preview-6749--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSerFeng JSerFeng changed the title fix: code-splitting should not regenerate chunk perf: code-splitting should not regenerate chunk Jun 6, 2024
@github-actions github-actions bot added release: performance release: performance related release(mr only) and removed release: bug fix release: bug related release(mr only) labels Jun 6, 2024
@JSerFeng JSerFeng marked this pull request as ready for review June 6, 2024 19:26
@JSerFeng JSerFeng requested a review from SyMind June 6, 2024 19:26
@SyMind SyMind merged commit ab29958 into main Jun 7, 2024
68 checks passed
@SyMind SyMind deleted the fix/code-splitting-re-calc branch June 7, 2024 02:32
@SyMind
Copy link
Member

SyMind commented Jun 11, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Jun 11, 2024

📝 Benchmark detail: Open

Name Base (2024-06-11 34bb9ea) Current Change
10000_development-mode + exec 2.24 s ± 26 ms 2.23 s ± 26 ms -0.29 %
10000_development-mode_hmr + exec 737 ms ± 14 ms 740 ms ± 7.2 ms +0.40 %
10000_production-mode + exec 2.58 s ± 21 ms 2.59 s ± 29 ms +0.24 %
arco-pro_development-mode + exec 1.92 s ± 78 ms 1.91 s ± 76 ms -0.55 %
arco-pro_development-mode_hmr + exec 441 ms ± 1.3 ms 442 ms ± 2.5 ms +0.12 %
arco-pro_production-mode + exec 3.51 s ± 71 ms 3.52 s ± 82 ms +0.25 %
threejs_development-mode_10x + exec 1.41 s ± 15 ms 1.4 s ± 12 ms -0.67 %
threejs_development-mode_10x_hmr + exec 802 ms ± 6.9 ms 807 ms ± 7.9 ms +0.63 %
threejs_production-mode_10x + exec 4.71 s ± 20 ms 4.7 s ± 32 ms -0.06 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants