Skip to content

Commit

Permalink
Revert "feat: for artifact-name (#43)" (#46)
Browse files Browse the repository at this point in the history
This reverts commit b61ddba.
  • Loading branch information
SyMind committed Jul 4, 2024
1 parent b61ddba commit 3061655
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 40 deletions.
6 changes: 3 additions & 3 deletions .github/actions/build-rspack/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ inputs:
description: "The version of Node.js to set up"
required: true
default: "18"

outputs:
artifact-name:
description: "The name of the uploaded artifact"
required: true
default: "binding-linux-x64-gnu"

runs:
using: composite
Expand All @@ -45,7 +45,7 @@ runs:
--js true
- uses: actions/download-artifact@v4
with:
name: ${{ inputs.artifact-name }}
name: binding-linux-x64-gnu
path: ${{ inputs.path }}/crates/node_binding
- name: Show restored binding
shell: bash
Expand Down
26 changes: 0 additions & 26 deletions .github/actions/check-latest-commit/action.yaml

This file was deleted.

2 changes: 0 additions & 2 deletions .github/actions/prepare-rspack-binding/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,3 @@ runs:
name: binding-linux-x64-gnu
path: ${{ inputs.path }}/crates/node_binding/*.node
compression-level: 9
- shell: bash
run: echo "artifact-name=binding-linux-x64-gnu" >> $GITHUB_OUTPUT
8 changes: 0 additions & 8 deletions .github/workflows/bench_rspack_commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,6 @@ jobs:
pattern: benchmark-artifacts-*
path: output
merge-multiple: true
- id: check-latest-commit
name: Check latest commit
uses: ./.github/actions/check-latest-commit
with:
path: ${{ env.RSPACK_DIR }}
- name: Upload result
if: ${{ steps.check-latest-commit.outputs.result == 'true' }}
run: node bin/upload.js ${{ secrets.GITHUB_TOKEN }}
- id: print-results
name: Print results
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:
- uses: ./.github/actions/build-rspack
with:
path: ${{ env.RSPACK_DIR }}
artifact-name: ${{ needs.prepare-binding.outputs.artifact-name }}
- name: Run benchmark
run: node bin/cli.js bench --shard ${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
- id: print-compare-results
Expand Down

0 comments on commit 3061655

Please sign in to comment.