Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format all files #3369

Merged
merged 2 commits into from
Sep 3, 2024
Merged

chore: format all files #3369

merged 2 commits into from
Sep 3, 2024

Conversation

chenjiahan
Copy link
Member

Summary

Use prettier to format all files.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 7378036
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66d7179f03a877000888a4b3
😎 Deploy Preview https://deploy-preview-3369--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 3bffc94 into main Sep 3, 2024
9 checks passed
@chenjiahan chenjiahan deleted the format_files_0903 branch September 3, 2024 14:13
@fi3ework
Copy link
Member

fi3ework commented Sep 3, 2024

It's just curious about why there's no use of Biome to format all files, especially some files are just normal TS files. 🤔

@chenjiahan
Copy link
Member Author

See #2669

We can mix Biome and Prettier, but I haven't seen much benefit.

@chenjiahan chenjiahan mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants