Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define NODE_ENV conflicts when setting mode #3159

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Aug 8, 2024

Summary

Fix define NODE_ENV conflicts when setting mode, Rspack already defines process.env.NODE_ENV by Rspack's mode, so Rsbuild do not need to define it again.

截屏2024-08-08 10 55 16

Related Links

https://rspack.dev/config/mode

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit f779331
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66b433b5d084e60008feb2e1
😎 Deploy Preview https://deploy-preview-3159--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 21 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 0312f9b into main Aug 8, 2024
11 checks passed
@chenjiahan chenjiahan deleted the set_mode_0808 branch August 8, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant