Skip to content

Commit

Permalink
chore(deps): update playwright monorepo to v1.46.1 (#2725)
Browse files Browse the repository at this point in the history
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: neverland <chenjiahan.jait@bytedance.com>
  • Loading branch information
renovate[bot] and chenjiahan committed Sep 1, 2024
1 parent 255e8bc commit 5ae0c59
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 30 deletions.
4 changes: 2 additions & 2 deletions e2e/cases/node-addons/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test('should compile Node addons correctly', async () => {

// the `test.darwin.node` is only compatible with darwin
if (process.platform === 'darwin') {
const content = await import('./dist/index.js' as string);
const { default: content } = await import('./dist/index.js' as string);
expect(typeof content.default.readLength).toEqual('function');
}
});
Expand Down Expand Up @@ -66,7 +66,7 @@ test('should compile Node addons in the node_modules correctly', async () => {
expect(fs.existsSync(join(__dirname, 'dist', 'other.node'))).toBeTruthy();

if (process.platform === 'darwin') {
const content = await import('./dist/index.js' as string);
const { default: content } = await import('./dist/index.js' as string);
expect(typeof content.default.readLength).toEqual('function');
}
});
4 changes: 2 additions & 2 deletions e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"devDependencies": {
"@e2e/helper": "workspace:*",
"@playwright/test": "1.44.1",
"@playwright/test": "1.46.1",
"@rsbuild/core": "workspace:*",
"@rsbuild/plugin-assets-retry": "workspace:*",
"@rsbuild/plugin-babel": "workspace:*",
Expand Down Expand Up @@ -49,7 +49,7 @@
"create-rsbuild": "workspace:*",
"fast-glob": "^3.3.2",
"fs-extra": "^11.2.0",
"playwright": "1.44.1",
"playwright": "1.46.1",
"strip-ansi": "6.0.1",
"tailwindcss": "^3.4.10",
"typescript": "^5.5.2"
Expand Down
12 changes: 8 additions & 4 deletions packages/core/src/plugins/rsdoctor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ type RsdoctorExports = {
RsdoctorWebpackPlugin: { new (): BundlerPluginInstance };
};

type MaybeRsdoctorPlugin = Configuration['plugins'] & { isRsdoctorPlugin?: boolean };
type MaybeRsdoctorPlugin = Configuration['plugins'] & {
isRsdoctorPlugin?: boolean;
};

export const pluginRsdoctor = (): RsbuildPlugin => ({
name: 'rsbuild:rsdoctor',
Expand Down Expand Up @@ -50,12 +52,14 @@ export const pluginRsdoctor = (): RsbuildPlugin => ({

let isAutoRegister = false;

const isRsdoctorPlugin = (plugin: MaybeRsdoctorPlugin) => plugin?.isRsdoctorPlugin === true || plugin?.constructor?.name === pluginName;
const isRsdoctorPlugin = (plugin: MaybeRsdoctorPlugin) =>
plugin?.isRsdoctorPlugin === true ||
plugin?.constructor?.name === pluginName;

for (const config of bundlerConfigs) {
// If user has added the Rsdoctor plugin to the config file, it will return.
const registered = config.plugins?.some(
(plugin) => isRsdoctorPlugin(plugin as unknown as MaybeRsdoctorPlugin),
const registered = config.plugins?.some((plugin) =>
isRsdoctorPlugin(plugin as unknown as MaybeRsdoctorPlugin),
);

if (registered) {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-assets-retry/src/AsyncChunkRetryPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class AsyncChunkRetryPlugin implements Rspack.RspackPluginInstance {
)
.replaceAll(
'__RUNTIME_GLOBALS_GET_MINI_CSS_EXTRACT_FILENAME__',
'__webpack_require__.miniCssF'
'__webpack_require__.miniCssF',
)
.replaceAll('__RUNTIME_GLOBALS_PUBLIC_PATH__', RuntimeGlobals.publicPath)
.replaceAll('__RUNTIME_GLOBALS_LOAD_SCRIPT__', RuntimeGlobals.loadScript)
Expand Down
36 changes: 18 additions & 18 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions website/docs/en/guide/basic/unocss.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@ You can register the `unocss` PostCSS plugin through [postcss.config.mjs](https:
import UnoCSS from '@unocss/postcss';

export default {
plugins: [
UnoCSS(),
],
plugins: [UnoCSS()],
};
```

Expand Down

0 comments on commit 5ae0c59

Please sign in to comment.