fix: escape characters in compilationId (#3334)

web-infra-dev · Sep 1, 2024 · 30e465c · 30e465c
1 parent 9a476f8
commit 30e465c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/core/src/server/helper.ts b/packages/core/src/server/helper.ts
@@ -384,9 +384,13 @@ export const getAddressUrls = ({
 };
 
 // A unique name for WebSocket communication
+const COMPILATION_ID_REGEX = /[^a-zA-Z0-9_-]/g;
 export const getCompilationId = (
   compiler: Rspack.Compiler | Rspack.Compilation,
-) => `${compiler.name ?? ''}_${compiler.options.output.uniqueName ?? ''}`;
+) => {
+  const uniqueName = compiler.options.output.uniqueName ?? '';
+  return `${compiler.name ?? ''}_${uniqueName.replace(COMPILATION_ID_REGEX, '_')}`;
+};
 
 export function getServerTerminator(
   server: Server | Http2SecureServer,