perf(plugin-react): reduce deepmerge overhead (#1481)

web-infra-dev · Jan 31, 2024 · 0a166ba · 0a166ba
1 parent b467588
commit 0a166ba
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 22 deletions.
diff --git a/packages/plugin-preact/src/index.ts b/packages/plugin-preact/src/index.ts
@@ -1,9 +1,5 @@
 import type { RsbuildPlugin } from '@rsbuild/core';
-import {
-  deepmerge,
-  modifySwcLoaderOptions,
-  type SwcReactConfig,
-} from '@rsbuild/shared';
+import { modifySwcLoaderOptions, type SwcReactConfig } from '@rsbuild/shared';
 
 export type PluginPreactOptions = {
   /**
@@ -39,14 +35,14 @@ export const pluginPreact = (
 
       modifySwcLoaderOptions({
         chain,
-        modifier: (options) => {
-          return deepmerge(options, {
-            jsc: {
-              transform: {
-                react: reactOptions,
-              },
-            },
-          });
+        modifier: (opts) => {
+          opts.jsc ??= {};
+          opts.jsc.transform ??= {};
+          opts.jsc.transform.react = {
+            ...opts.jsc.transform.react,
+            ...reactOptions,
+          };
+          return opts;
         },
       });
     });

diff --git a/packages/plugin-react/src/react.ts b/packages/plugin-react/src/react.ts
@@ -1,6 +1,5 @@
 import path from 'node:path';
 import {
-  deepmerge,
   isUsingHMR,
   modifySwcLoaderOptions,
   type SwcReactConfig,
@@ -27,14 +26,14 @@ export const applyBasicReactSupport = (
 
     modifySwcLoaderOptions({
       chain,
-      modifier: (options) => {
-        return deepmerge(options, {
-          jsc: {
-            transform: {
-              react: reactOptions,
-            },
-          },
-        });
+      modifier: (opts) => {
+        opts.jsc ??= {};
+        opts.jsc.transform ??= {};
+        opts.jsc.transform.react = {
+          ...opts.jsc.transform.react,
+          ...reactOptions,
+        };
+        return opts;
       },
     });