Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for enabling and disabling async replication in schema #1105

Merged
merged 13 commits into from
Jun 27, 2024

Conversation

jeroiraz
Copy link
Contributor

@jeroiraz jeroiraz commented Jun 12, 2024

This can be used ONLY with Weaviate Server v1.26.0 or later. This can be configured in class schema like this:

my_class = {
    "class": "MyClass",
    ...,
    "replicationConfig": {
        "factor": 1,
        "async_enabled": true
    }
}

@jeroiraz jeroiraz requested a review from tsmith023 June 12, 2024 13:25
@jeroiraz jeroiraz force-pushed the feat_async_rep branch 6 times, most recently from b921220 to 9f2c118 Compare June 13, 2024 14:13
…This can be used `ONLY` with Weaviate Server ``v1.26.0`` or later. This can be configured in class schema like this:

        .. code-block:: python

            my_class = {
                "class": "MyClass",
                ...,
                "replicationConfig": {
                    "factor": 1,
                    "async_enabled": true
                }
            }

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

test: ajust test cases to support asyncRep

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

chore: use snake case for async replication

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

test: ajust test cases to support asyncRep

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

chore: handle optional async_enabled attribute

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

chore: add missing colon in payload

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

chore: linter changes

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

test: parametrize replication config

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>

test: parametrize replication config

Signed-off-by: Jeronimo <jeronimo.irazabal@gmail.com>
This commit fixes some misreferences to the asyncEnabled
property which were using async_enabled instead.
weaviate/collections/classes/config_methods.py Outdated Show resolved Hide resolved
weaviate/schema/crud_schema.py Outdated Show resolved Hide resolved
weaviate/collections/classes/config.py Show resolved Hide resolved
integration_v3/test_schema.py Show resolved Hide resolved
@tsmith023 tsmith023 requested a review from a team as a code owner June 26, 2024 10:45
@tsmith023 tsmith023 changed the base branch from main to dev/1.26 June 26, 2024 11:01
@tsmith023 tsmith023 requested a review from dirkkul June 27, 2024 08:46
.github/workflows/main.yaml Show resolved Hide resolved
.github/workflows/main.yaml Show resolved Hide resolved
integration/test_collection_config.py Show resolved Hide resolved
integration/test_collection_config.py Outdated Show resolved Hide resolved
@dirkkul dirkkul merged commit ff845d1 into dev/1.26 Jun 27, 2024
45 checks passed
@dirkkul dirkkul deleted the feat_async_rep branch June 27, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants