Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Copy kubernetes version from machine into cluster on apply if cluster value is not set #319

Merged

Conversation

jrryjcksn
Copy link
Contributor

Currently, wk only sets kubernetes versions on machines, not on the cluster. This PR copies that value across if the cluster does not already have one.

@jrryjcksn jrryjcksn self-assigned this Dec 1, 2020
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@jrryjcksn jrryjcksn merged commit 61d9e53 into master Dec 2, 2020
@jrryjcksn jrryjcksn deleted the WKP-1542/make-upgrade-work-with-versions-only-on-machines branch December 2, 2020 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants