Add everything! #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At the time of writing, coveralls is down, so we'll have to wait to see if reports are working. |
Avaq
force-pushed
the
avaq/everything
branch
3 times, most recently
from
867ce83
to
539ed74
Compare
paolobueno
previously approved these changes
Jul 11, 2018
paolobueno
reviewed
Jul 11, 2018
| eq (typeof result.types) ('object'); | ||
| eq (result.reducer ({}, {type: 'Warped/Test/foo', payload: 'test'})) | ||
| ({actionPayload: 'test'}); | ||
| eq (result.types) ({foo: 'Warped/Test/foo'}); |
There was a problem hiding this comment.
The space before function params really makes it look like a different language!
There was a problem hiding this comment.
That's the trick. See sanctuary-js/sanctuary#438 :)
paolobueno
reviewed
Jul 11, 2018
| //. Usage in Node depends on `--experimental-modules`. | ||
| //. With older Node versions, use [std/esm][2]. | ||
|
|
||
| // createType :: (String, String) -> String |
There was a problem hiding this comment.
That's https://github.com/plaid/transcribe under the hood.
|
There we go. With Coveralls working, this work should be ready for a merge. |
paolobueno
previously approved these changes
Jul 12, 2018
paolobueno
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.