MVP #51
Open
MVP #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
primaulia
reviewed
Jan 11, 2018
|
|
||
| // =============== middleware =============== | ||
| app.set('views', path.join(__dirname, 'views')); | ||
| app.set('view engine', 'ejs'); |
primaulia
reviewed
Jan 11, 2018
| photo: String, | ||
| location: String, | ||
| date: String, | ||
| like: [String], |
There was a problem hiding this comment.
So i can like multiple times for the same review?
primaulia
reviewed
Jan 11, 2018
| date: String, | ||
| like: [String], | ||
| comments: [{ | ||
| username: String, |
There was a problem hiding this comment.
You should reference the comment to an actual user model
primaulia
reviewed
Jan 11, 2018
| return done(null, false, { message: 'Incorrect username' }); | ||
| } | ||
|
|
||
| bcrypt.compare(password, user.password, function(err, isMatch) { |
There was a problem hiding this comment.
Any specific reasons why you compare it here instead of doing it in the model instead?
primaulia
reviewed
Jan 11, 2018
| profilePic: helper.randomProfile() | ||
| }); | ||
|
|
||
| bcrypt.hash(newUser.password, saltRounds, function(err, hash) { |
There was a problem hiding this comment.
Any reason why you didn't put this in model instead?
primaulia
reviewed
Jan 11, 2018
public/js/main.js
Outdated
| url: $(this).attr('href'), | ||
| type: 'DELETE', | ||
| success: function(data) { | ||
| console.log(data); |
There was a problem hiding this comment.
clear all of your console.log once you're done with it
primaulia
reviewed
Jan 11, 2018
| @@ -0,0 +1,23 @@ | |||
| <!DOCTYPE html> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5):
Completeness Level (1-5):
What did you think of this deliverable?: