Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRL versions to match RFC 5280. #7

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Update CRL versions to match RFC 5280. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd2020
Update CRL versions to match RFC 5280.
vinas003 Oct 29, 2022
8da1a71
Merge branch 'wbond:master' into master
vinas003 Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crlbuilder/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ def _make_extension(name, value):
})

tbs_cert_list = crl.TbsCertList({
'version': 'v3',
'version': 'v2',
'signature': {
'algorithm': signature_algorithm_id
},
Expand Down
6 changes: 3 additions & 3 deletions tests/test_certificate_list_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def test_build_basic_crl(self):

now = datetime.now(timezone.utc)

self.assertEqual('v3', tbs_cert_list['version'].native)
self.assertEqual('v2', tbs_cert_list['version'].native)
self.assertEqual('rsassa_pkcs1v15', tbs_cert_list['signature'].signature_algo)
self.assertEqual('sha256', tbs_cert_list['signature'].hash_algo)
self.assertEqual(root_certificate.asn1.subject, tbs_cert_list['issuer'])
Expand Down Expand Up @@ -109,7 +109,7 @@ def test_build_indirect_crl(self):

now = datetime.now(timezone.utc)

self.assertEqual('v3', tbs_cert_list['version'].native)
self.assertEqual('v2', tbs_cert_list['version'].native)
self.assertEqual('rsassa_pkcs1v15', tbs_cert_list['signature'].signature_algo)
self.assertEqual('sha256', tbs_cert_list['signature'].hash_algo)
self.assertEqual(crl_issuer_certificate.asn1.subject, tbs_cert_list['issuer'])
Expand Down Expand Up @@ -182,7 +182,7 @@ def test_build_delta_crl(self):

now = datetime.now(timezone.utc)

self.assertEqual('v3', tbs_cert_list['version'].native)
self.assertEqual('v2', tbs_cert_list['version'].native)
self.assertEqual('rsassa_pkcs1v15', tbs_cert_list['signature'].signature_algo)
self.assertEqual('sha256', tbs_cert_list['signature'].hash_algo)
self.assertEqual(crl_issuer_certificate.asn1.subject, tbs_cert_list['issuer'])
Expand Down
Loading