Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test case for duplicate registry entries. #998

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

antoniomanuelfr
Copy link
Contributor

Hello team,

This PR aims to add a new test as explained in #732

Closes #732

Tests logic

The test will monitor the following configuration:

    <windows_registry>HKLM\software\key1</windows_registry>
    <windows_registry>HKLM\\software\key1,HKLM\\software\key2,HKLM\\software\key3,...<windows_registry>

The test will create events in all the monitored keys and wait for the expected events.

Tests checks

  • Proven that tests pass when they have to pass
  • Proven that tests fail when they have to fail

Best regards.

@antoniomanuelfr
Copy link
Contributor Author

This is the HTML report of the ambiguous confs integration tests:
report.zip

Copy link
Member

@jotacarma90 jotacarma90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team!

I run the test on a modified agent that had the bug that started this issue/PR and it properly fails on the cases we expected. GJ!

The report with the failed cases can be found here: fail-case.zip

@vikman90 vikman90 merged commit bc79bc4 into master Jan 13, 2021
@vikman90 vikman90 deleted the 732-add-new-case-for-duplicate-entries branch January 13, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required new test to check syscheck configuration with duplicated directories and registries.
4 participants