Fix data visualization script graphics generation #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGP1
force-pushed
the
fix/4975-data-visualization-script
branch
from
5f44e31
to
64726e9
Compare
Selutario
suggested changes
Feb 29, 2024
There was a problem hiding this comment.
Looks good! Just an additional request: please, add a changelog entry for these changes.
Edit: it seems two minor changes are also needed for the linter check to pass:
GGP1
force-pushed
the
fix/4975-data-visualization-script
branch
from
64726e9
to
645ec52
Compare
Selutario
previously approved these changes
Feb 29, 2024
rauldpm
previously approved these changes
Feb 29, 2024
GGP1
force-pushed
the
fix/4975-data-visualization-script
branch
2 times, most recently
from
c00f1b3
to
f9a01e6
Compare
GGP1
force-pushed
the
fix/4975-data-visualization-script
branch
2 times, most recently
from
a8113c8
to
83415a3
Compare
GGP1
force-pushed
the
fix/4975-data-visualization-script
branch
from
83415a3
to
1bfd713
Compare
Selutario
approved these changes
Mar 7, 2024
rauldpm
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some errors from the data visualization script during the cluster, analysisd and remoted statistics graphics generation.
Build: https://ci.wazuh.info/job/CLUSTER-Workload_benchmarks_metrics/482/
Artifacts: artifacts_logcollector.zip
The graphic generation is failing because the pull request #5007 was merged and now the
analysisdandremotedstatistics are gathered from the API endpoints instead of the.statefiles, and the visualization script hasn't been updated.The changes introduced in this pull request fix the graphics generation for the
logcollectordstatistics files only. To generate graphics using the files containing statistics from the API, a script refactor is needed. We've opened #5022 to work on that.Testing performed