Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Integration tests README #4742

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Update Integration tests README #4742

merged 8 commits into from
Jan 4, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Dec 5, 2023

Related issue
#4711

Description

This PR update the Integration Tests README file.

Updated

  • Update Integration tests README.

@Rebits Rebits self-assigned this Dec 5, 2023
@Rebits Rebits linked an issue Dec 5, 2023 that may be closed by this pull request
Update Integration tests readme #4711
Closed
@Rebits Rebits force-pushed the 4711-update-readme branch 2 times, most recently from ad89b4e to 3503f29 Compare December 7, 2023 16:51
@Rebits Rebits marked this pull request as ready for review December 7, 2023 16:51
@Rebits Rebits force-pushed the 4711-update-readme branch 5 times, most recently from 05ebcfa to a579ccc Compare December 7, 2023 16:55
pro-akim
pro-akim requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@pro-akim pro-akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the setting of internal options be retained?
Checking the pipeline currently running the process, these internal options remain effective when running the test.

tests/integration/README.md
```

- Add some internal options and restart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from installing dependencies,
Shouldn't the setting of internal options be retained?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 15215b3

tests/integration/README.md
```

- Change `time-reconnect` from `C:\Program Files (x86)\ossec-agent\ossec.conf`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More internal options to take into consideration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 15215b3

tests/integration/README.md
```

- Add some internal options and restart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More internal options to take into consideration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 15215b3

@Rebits
Copy link
Member Author

Rebits commented Dec 14, 2023 •
edited
Loading

Regarding the local internal options. In order to streamline the maintenance process for local internal options, it is essential to ensure that integration tests possess the capability to configure every aspect necessary for their execution independently.

If a particular set of local configuration options or specific agent configurations is essential for all integration tests, it is advised to incorporate these configurations directly into the respective tests. This approach ensures clarity and self-sufficiency in each test.

However, it's acknowledged that there may be instances where certain options are required for outdated tests. For these reasons I will reverse some those removal.

@Rebits Rebits changed the base branch from 4.8.0 to 4.8.1 January 3, 2024 14:23
@pro-akim pro-akim self-requested a review January 3, 2024 15:24
pro-akim
pro-akim approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@pro-akim pro-akim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Notes

LGTM

tests/integration/README.md Outdated
- Install Python and its dependencies
- Install Python3

```sheel script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix to shell

@davidjiglesias davidjiglesias merged commit 2a8e72a into 4.8.1 Jan 4, 2024
3 of 4 checks passed
@davidjiglesias davidjiglesias deleted the 4711-update-readme branch January 4, 2024 09:26
@pro-akim pro-akim mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-akim pro-akim pro-akim approved these changes

Assignees

@Rebits Rebits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Integration tests readme
3 participants
@Rebits @pro-akim @davidjiglesias