Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize multiple wday tests (GCloud integration) #4176

Merged
merged 3 commits into from
May 29, 2023

Conversation

mauromalara
Copy link
Contributor

@mauromalara mauromalara commented May 16, 2023

Related issue
#4161

Description

Several test cases were marked as xfail, but only 1 of them was unstable. So, this PR removes the markers in those tests and makes some improvements in the test structure.

Updated

  • tests/integration/test_gcloud/test_functionality/test_day_wday.py

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@mauromalara (Developer) tests/integration/test_gcloud/test_functionality/test_day_wday.py - 🟢 🟢 🟢 a900515 Nothing to highlight

Jenkins

Target Rounds Note
Agent 🔴🔴🔴 The pipeline for agents is not working yet.
Manager 🟢 🔴 🔴 All of the failures are not related with the changes and are unstable (some tests fail in a round, but in others don't)

@mauromalara mauromalara self-assigned this May 16, 2023
@mauromalara mauromalara linked an issue May 16, 2023 that may be closed by this pull request
@mauromalara
Copy link
Contributor Author

mauromalara commented May 18, 2023

Execution update

Tests were launched locally with 2 different packages (before the 4.4.2 tag and with the 4.4.2 tag) and did not fail.

Scenario Rounds
Launch tests with failures only - Before the 4.4.2 tag 🟢 🟢 🟢
Launch tests with failures only - With the 4.4.2 tag 🟢 🟢 🟢
Launch the entire GCloud suite - 4.4.2 🔴 🔴 🔴

I could not find anything locally, so I'll debug in Jenkins (where the tests are unstable):

Jenkis build 🔴


Seems like they are unstable when the entire suite is executed. Possibly it is a misconfigured setup/teardown stage.

@mauromalara
Copy link
Contributor Author

mauromalara commented May 24, 2023

Execution update

Local Jenkins
🟢 🟢 🟢 🟢 🟢 🔴

Note: I executed an extra build after an hour to check if there was an issue with GCP and it also fails 🔴

So, the tests will be marked as "expected to fail" (xfail) until they can be unmarked in this issue: wazuh/wazuh#17245

@mauromalara mauromalara force-pushed the 4161-stabilize-multiple-wday-tests branch from a900515 to 54b5fb5 Compare May 24, 2023 15:12
@mauromalara
Copy link
Contributor Author

mauromalara commented May 24, 2023

Results with latest changes

Jenkins
🟢 🟢 🟢

@mauromalara mauromalara force-pushed the 4161-stabilize-multiple-wday-tests branch from df14dd6 to 3620798 Compare May 29, 2023 16:08
Remove unused imports.
Change the way the datetime information was set in the test module
@mauromalara mauromalara force-pushed the 4161-stabilize-multiple-wday-tests branch from 3620798 to 1ea20f4 Compare May 29, 2023 18:11
@damarisg damarisg merged commit b421414 into 4.4 May 29, 2023
@damarisg damarisg deleted the 4161-stabilize-multiple-wday-tests branch May 29, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are unexpectedly passing (API and GCloud)
2 participants