Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve versioning of the wazuh testing framework #4172

Merged
merged 9 commits into from
May 26, 2023
Merged

Improve versioning of the wazuh testing framework #4172

merged 9 commits into from
May 26, 2023

Conversation

verdx
Copy link
Contributor

@verdx verdx commented May 16, 2023

Related issue
#4171

Description

Changed the last occurrences of 4.4.0 where 4.4.2 was needed

@verdx verdx self-assigned this May 16, 2023
@verdx verdx force-pushed the 4171-bump-missing-files-to-4.4.2 branch from bf2d6a8 to af3a887 Compare May 16, 2023 12:42
@verdx
docs(#4171): Add changes to changelog
023a1b3 
Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>
mauromalara
mauromalara suggested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I requested a change in the CHANGELOG.md file because you are not changing anything in the tests.

CHANGELOG.md Outdated Show resolved Hide resolved
mauromalara

This comment was marked as duplicate.

Sign in to view

@verdx @mauromalara
docs(#4171): Update CHANGELOG.md
2bcf993 
Co-authored-by: Mauro Agustín Malara Zapata <39094716+mauromalara@users.noreply.github.com>
@verdx verdx requested a review from mauromalara May 16, 2023 14:33
Deblintrake09
Deblintrake09 suggested changes May 16, 2023
View reviewed changes
deps/wazuh_testing/setup.py Outdated Show resolved Hide resolved
@verdx
fix(#4171): Parametrize the version in setup.py
0f9b19c 
Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>
mauromalara
mauromalara suggested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a little testing task is required IMHO.

deps/wazuh_testing/setup.py Outdated Show resolved Hide resolved
@verdx
fix(#4171): Change path to relative from setup.py's location
8d4a1f1 
Signed-off-by: Miguel Verdaguer Velázquez <verdx@riseup.net>
@verdx verdx requested a review from mauromalara May 16, 2023 15:38
mauromalara
mauromalara approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verdx verdx linked an issue May 19, 2023 that may be closed by this pull request
Change occurrences of 4.4.0 in branch 4.4 to 4.4.2 #4171
Closed
@Rebits Rebits changed the title Changed occurrences of 4.4.0 in branch 4.4 to 4.4.2 Improve versioning of the wazuh_testing framework May 26, 2023
@Rebits Rebits force-pushed the 4171-bump-missing-files-to-4.4.2 branch from 1307c52 to 1c2b784 Compare May 26, 2023 12:31
@Rebits Rebits changed the title Improve versioning of the wazuh_testing framework Improve versioning of the wazuh testing framework May 26, 2023
@Rebits Rebits merged commit fb45f37 into 4.4 May 26, 2023
@Rebits Rebits deleted the 4171-bump-missing-files-to-4.4.2 branch May 26, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rebits Rebits Rebits approved these changes

@Deblintrake09 Deblintrake09 Deblintrake09 approved these changes

@mauromalara mauromalara mauromalara approved these changes

@jnasselle jnasselle Awaiting requested review from jnasselle

@roronoasins roronoasins Awaiting requested review from roronoasins

@juliamagan juliamagan Awaiting requested review from juliamagan

Assignees

@verdx verdx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change occurrences of 4.4.0 in branch 4.4 to 4.4.2
4 participants
@verdx @Rebits @Deblintrake09 @mauromalara