Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the way that environment data is managed #4059

Merged
merged 4 commits into from
May 24, 2023
Merged

Improve the way that environment data is managed #4059

merged 4 commits into from
May 24, 2023

Conversation

mauromalara
Copy link
Contributor

@mauromalara mauromalara commented Mar 28, 2023 •
edited
Loading

Related issue
#4058

Description

Remove the credentials from the code to set them in runtime.

Updated

  • deps/wazuh_testing/wazuh_testing/tools/migration_tool/__init__.py: Dict replaced by None type
  • deps/wazuh_testing/wazuh_testing/tools/migration_tool/utils.py: Change the way the credentials are used.

Testing performed

Testing was performed here.

@mauromalara mauromalara self-assigned this Mar 28, 2023
@mauromalara mauromalara changed the title feat(#4058): remove the default credentials from code. Improve the way that environment data is managed Mar 28, 2023
mauromalara added a commit that referenced this pull request Mar 29, 2023
@mauromalara
fix(#4059): fix importing a symbol instead of real var.
511964c
mauromalara added a commit that referenced this pull request Mar 29, 2023
@mauromalara
docs(#4059): add change to the changelog.
c945dc4
@mauromalara mauromalara linked an issue Mar 30, 2023 that may be closed by this pull request
Improve the way that environment data is managed #4058
Closed
mauromalara added a commit that referenced this pull request Apr 19, 2023
@mauromalara
fix(#4059): fix importing a symbol instead of real var.
008c99f
mauromalara added a commit that referenced this pull request Apr 19, 2023
@mauromalara
docs(#4059): add change to the changelog.
753f8a3
mauromalara added a commit that referenced this pull request Apr 19, 2023
@mauromalara
style(#4059): remove unused imports and fix CHANGELOG
00bc5f2
@damarisg damarisg merged commit 56666ee into 4.5 May 24, 2023
@damarisg damarisg deleted the 749-e2e-intelligence branch May 24, 2023 17:15
GGP1 pushed a commit that referenced this pull request Jun 2, 2023
@mauromalara @GGP1
Improve the way that environment data is managed (#4059)
68005bc 
* feat(#4058): remove the default credentials from code.

* fix(#4059): fix importing a symbol instead of real var.

* docs(#4059): add change to the changelog.

* style(#4059): remove unused imports and fix CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damarisg damarisg damarisg approved these changes

Assignees

@mauromalara mauromalara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the way that environment data is managed
2 participants
@mauromalara @damarisg