Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multigroups system test #3674

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Fix multigroups system test #3674

merged 3 commits into from
Dec 14, 2022

Conversation

Selutario
Copy link
Contributor

Related issue
#3647

Description

As reported in #3647, the multigroups test was failing when trying to use a non-defined API token variable. This PR applies some changes to fix the problem.

Updated

  • find_file: A parameter (file_type) was restored. Default value for pattern parameter was added.
  • get_api_token: This fixture has been converted to a normal function.

Testing performed

Tester Test path Jenkins Local OS Commit Notes
@Selutario (Developer) tests/system/test_multigroups ⚫⚫⚫ 🟢🟢🟢 Debian buster Nothing to highlight
@user (Reviewer) ⚫⚫⚫ 🚫 🚫 🚫 Nothing to highlight

@Selutario Selutario self-assigned this Dec 14, 2022
@Selutario Selutario linked an issue Dec 14, 2022 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
@jmv74211 jmv74211 merged commit 4a9c1a1 into 4.4 Dec 14, 2022
@jmv74211 jmv74211 deleted the 3647-multigroups-system-test branch December 14, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate the ERROR in the multigroups test
3 participants