Change method from GET to POST in API login requests
#2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicferpoy
suggested changes
Apr 21, 2022
mcarmona99
force-pushed
the
feature/2705-login-endpoint-method
branch
from
5b64c26
to
0ee2a14
Compare
damarisg
approved these changes
May 3, 2022
There was a problem hiding this comment.
Tests Results
| Test Path | Os/Type | Jenkins | Date | By |
|---|---|---|---|---|
| test_api/ | Manager | 🟢 🟢 🟢 | 03/05/2022 | Seyla |
Build package: https://ci.wazuh.info/job/Packages_builder/95111/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #2705.
Apart from the change listed in the related issue, I have added more changes to tests and tools using the login endpoint.
The related API tests will fail until wazuh/wazuh#10203 is merged.
Checks
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.