Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysisd - add new test to check the pre-decoding stage of analysisd #2406

Merged
merged 7 commits into from
Jan 27, 2022

Conversation

danisan90
Copy link
Contributor

Related issue
#1498

Description

Closes #1498

This PR adds a new test for Analysisd requested on the issue #1498 . To increase the integration test coverage, the test test_predecoder_stage.py was added for the pre-decoding stage of analysisd.

This test check:

  • The correct JSON response of the pre-decoder when it receives accepted syslog formats.

Tests

  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.
  • Python codebase is documented following the QA-Docs Schema 2.0.
  • provision_documentation.sh generate the docs without errors.

mauromalara
mauromalara previously approved these changes Dec 27, 2021
Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mauromalara mauromalara self-requested a review January 17, 2022 18:06
@mauromalara mauromalara dismissed their stale review January 17, 2022 18:07

The QA-docs tool was not run.

Copy link
Contributor

@mauromalara mauromalara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danisan90 Please, modify the code following the PEP8 guidelines. You can follow this guide to doing it, take into account that you must change the max-line-length argument following this guide

@mauromalara
Copy link
Contributor

OS Local Jenkins Notes
R1 🟢 🟢
R2 🟢 🟢
R3 🟢 🟢

mauromalara
mauromalara previously approved these changes Jan 19, 2022
@snaow snaow merged commit e0c742c into master Jan 27, 2022
@snaow snaow deleted the 1498-predecoder-stage-test branch January 27, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysisd - IT for the pre-decoder stage
4 participants