-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for max_upload_size API option #1494
Conversation
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ, but some changes are required.
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/data/conf.yaml
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
docs/tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.md
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ, only it is necessary to use common repository fixtures.
tests/integration/test_api/test_config/test_max_upload_size/test_max_upload_size.py
Outdated
Show resolved
Hide resolved
ba01375
to
39bc159
Compare
649815c
to
f224581
Compare
Test result after applying
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Description
This PR adds a test to verify that a 413 status code (Request Entity Too Large) is returned if the body in an API request is bigger than
max_upload_size
, which is specified in theapi.yaml
file.Configuration options
None
Logs example
Tests
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py
.provision_documentation.sh
generate the docs without errors.Regards,
Selu.