Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remoted integration tests T1: Add test manager ACK #1109

Merged
merged 12 commits into from
Mar 5, 2021
Merged

Conversation

jmv74211
Copy link
Contributor

@jmv74211 jmv74211 commented Mar 5, 2021

Related issue
close #1102

Description

This PR adds a new test for checking if the manager sends the ACK message to the agent after receiving the start-up message. These changes are as follows:

  • Add test manager ACK pytest.
  • Add test manager ACK documentation.
  • Refactor Agent simulator event queue. Now it is implemented by monitoring.Queue queue.
  • Add a new function to monitor agent received messages.

Logs example

========================================== test session starts ==========================================
test_remoted/test_manager_messages/test_manager_ack.py::test_manager_ack[TCP] PASSED              [ 25%]
test_remoted/test_manager_messages/test_manager_ack.py::test_manager_ack[UDP] PASSED              [ 50%]
test_remoted/test_manager_messages/test_manager_ack.py::test_manager_ack[TCP,UDP] PASSED          [ 75%]
test_remoted/test_manager_messages/test_manager_ack.py::test_manager_ack[UDP,TCP] PASSED          [100%]

===================================== 4 passed in 75.76s (0:01:15) ======================================

Tests

  • Proven that tests pass when they have to pass.
  • Proven that tests fail when they have to fail.
  • Python codebase satisfies PEP-8 style style guide. pycodestyle --max-line-length=120 --show-source --show-pep8 file.py
  • Python codebase is documented following the Google Style for Python docstrings.
  • The test is documented in wazuh-qa/docs

@jmv74211 jmv74211 requested a review from BraulioV March 5, 2021 10:52
@jmv74211 jmv74211 self-assigned this Mar 5, 2021
@BraulioV BraulioV merged commit 72ccd0e into master Mar 5, 2021
@BraulioV BraulioV deleted the 1102-manager-ack branch March 5, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remoted integration tests T1: Check manager ACK after receiving the start-up message of the agent
2 participants