Deprecate ossec-init.conf #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraulioV
suggested changes
Jan 29, 2021
spothound
force-pushed
the
1007-init-conf
branch
from
83199bc
to
6d5b1e9
Compare
BraulioV
previously approved these changes
Jan 29, 2021
spothound
force-pushed
the
1007-init-conf
branch
from
6d5b1e9
to
b222e92
Compare
spothound
force-pushed
the
1007-init-conf
branch
from
b222e92
to
0441166
Compare
BraulioV
suggested changes
Jan 29, 2021
There was a problem hiding this comment.
Check the requested changes. Also, the function get_current_version is basically the same both for manager and agents but, the agent's version will fail for Solaris and macOS systems.
What I mean by this is I would love to see both functions merged in a single one and imported by the test.
spothound
force-pushed
the
1007-init-conf
branch
5 times, most recently
from
8bcdf00
to
67496df
Compare
BraulioV
suggested changes
Feb 1, 2021
spothound
force-pushed
the
1007-init-conf
branch
10 times, most recently
from
57c90d5
to
a755d0d
Compare
spothound
force-pushed
the
1007-init-conf
branch
from
a755d0d
to
d199df4
Compare
BraulioV
previously approved these changes
Feb 3, 2021
palaciosjeremias
suggested changes
Feb 5, 2021
BraulioV
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
This issue introduced required changes in our tests to remove
ossec-init.confdeprecated file.Closes #1007
Closes https://github.com/wazuh/wazuh-jenkins/issues/2243