Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some cases in test_ignore_valid, to check entire disk ignore #1000

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Added some cases in test_ignore_valid, to check entire disk ignore #1000

merged 2 commits into from
Feb 1, 2021

Conversation

jotacarma90
Copy link
Member

Description

This PR adds a new case into test_ignore_valid to check that the entire disk is ignored when using:
c:.

It's related to this issue:
wazuh/wazuh#5252

Configuration

<directories check_all="yes" whodata="yes">c:\testdir1,c:\testdir2</directories>
<ignore>c:\.</ignore>
  • No events should appear in those folders

antoniomanuelfr
antoniomanuelfr approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@antoniomanuelfr antoniomanuelfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikman90 vikman90 merged commit a43b673 into master Feb 1, 2021
@vikman90 vikman90 deleted the 5252-added-cases-to-ignore branch February 1, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molter73 Molter73 Molter73 approved these changes

@antoniomanuelfr antoniomanuelfr antoniomanuelfr approved these changes

Assignees

@jotacarma90 jotacarma90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jotacarma90 @Molter73 @antoniomanuelfr @vikman90