Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automated tests related to Syscollector deltas to new format #3673

Closed
jnasselle opened this issue Dec 14, 2022 · 2 comments · Fixed by #3695
Closed

Update automated tests related to Syscollector deltas to new format #3673

jnasselle opened this issue Dec 14, 2022 · 2 comments · Fixed by #3695
Assignees
@jnasselle @Dwordcito
Labels
feature/syscollector

Comments

@jnasselle
Copy link
Member

jnasselle commented Dec 14, 2022 •
edited
Loading

Target version Related issue Related PR
v4.4 wazuh/wazuh#15639 wazuh/wazuh#15675

Description

This issue aims to update the integration tests related to syscollector deltas, which are

Both integration tests were developed here #2146

Proposed updates

  • Analysisd IT
    • Replace partial modified/inserted deltas to contain all the information
    • Alerts expected values (fields and rules numbers) should be the same, only updating values that may be changed according to the event input
  • Wazuh-db IT
    • Replace partial modified/inserted deltas to contain all the information
    • Change format from pipe-separated masked values with JSON format
    • Change error return depending the proposed changes
@jnasselle jnasselle changed the title Update automated tests related to Syscollector deltas to new fully Update automated tests related to Syscollector deltas to new format Dec 14, 2022
@jnasselle jnasselle mentioned this issue Dec 14, 2022
Closed
17 tasks
@jmv74211 jmv74211 added this to the Release 4.4.0 milestone Dec 16, 2022
Dwordcito added a commit that referenced this issue Dec 21, 2022
@Dwordcito
fix(#3673): modify analysisd delta tests.
fd7350d
Dwordcito added a commit that referenced this issue Dec 21, 2022
@Dwordcito
fix(#3673): modify analysisd delta tests.
e8d2f5a
@jnasselle jnasselle linked a pull request Dec 21, 2022 that will close this issue
Fix syscollector deltas integration tests #3695
Merged
@jnasselle jnasselle assigned jnasselle and Dwordcito and unassigned mauromalara Dec 21, 2022
Dwordcito added a commit that referenced this issue Dec 21, 2022
@Dwordcito
fix(#3673): modify analysisd delta tests.
bfeead3
jnasselle added a commit that referenced this issue Dec 22, 2022
@jnasselle
fix(#3673): modify wazuh-db delta tests.
99c48f8
jnasselle added a commit that referenced this issue Dec 22, 2022
@jnasselle
fix(#3673): modify wazuh-db delta tests.
1fd8317
jnasselle added a commit that referenced this issue Dec 22, 2022
@jnasselle
fix(#3673): modify wazuh-db delta tests.
1350711
jnasselle added a commit that referenced this issue Dec 22, 2022
@jnasselle
fix(#3673): modify wazuh-db delta tests.
8c58f8f
jnasselle added a commit that referenced this issue Dec 22, 2022
@jnasselle
fix(#3673): modify wazuh-db delta tests.
c6f66ae
@mauromalara
Copy link
Contributor

Update 29/12/2022

  • Had issues with the environment (Windows)
  • After debugging the test that was failing locally, we noticed that this behavior was only present in Ubuntu, while in CentOS the test passes. So, the issue has nothing to do with the current development.

jnasselle added a commit that referenced this issue Jan 6, 2023
@jnasselle
fix(#3673): Adapt test to netaddr proto
90d8ba4
Dwordcito added a commit that referenced this issue Jan 10, 2023
@Dwordcito @jnasselle
Fix syscollector deltas integration tests (#3695)
5cb5c54 
* fix(#3673): modify analysisd delta tests.

* fix(#3673): modify wazuh-db delta tests.

* fix(#3673): Adapt test to netaddr proto

Co-authored-by: jnasselle <jnasselle@gmail.com>
@jnasselle
Copy link
Member Author

Closed by #3695

Dwordcito added a commit that referenced this issue Jan 12, 2023
@Dwordcito @jnasselle
Fix syscollector deltas integration tests (#3695)
92e1657 
* fix(#3673): modify analysisd delta tests.

* fix(#3673): modify wazuh-db delta tests.

* fix(#3673): Adapt test to netaddr proto

Co-authored-by: jnasselle <jnasselle@gmail.com>
Dwordcito added a commit that referenced this issue Jan 13, 2023
@Dwordcito @jnasselle
Fix syscollector deltas integration tests (#3695) (#3748)
487a1eb 
* fix(#3673): modify analysisd delta tests.

* fix(#3673): modify wazuh-db delta tests.

* fix(#3673): Adapt test to netaddr proto

Co-authored-by: jnasselle <jnasselle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnasselle jnasselle

@Dwordcito Dwordcito

Labels
feature/syscollector
Projects
No open projects
Release 4.4.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix syscollector deltas integration tests wazuh/wazuh-qa
5 participants
@jnasselle @damarisg @Dwordcito @jmv74211 @mauromalara