Maintenance #38
Merged
Maintenance #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
granoff
approved these changes
Dec 4, 2023
1 task
bdunay3
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Updated testable combine publishers * Fixed Swift 6 conflicting generic aliases warning * Fixed Xcode 14.3 UI test bug * Update CI macOS and Xcode versions * build destination corrections * tidy up ci devices * Fix flaky tests * Upgrade actions * Temporarily™ disabled broken UI tests
bdunay3
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Updated testable combine publishers * Fixed Swift 6 conflicting generic aliases warning * Fixed Xcode 14.3 UI test bug * Update CI macOS and Xcode versions * build destination corrections * tidy up ci devices * Fix flaky tests * Upgrade actions * Temporarily™ disabled broken UI tests
albertbori
added a commit
that referenced
this pull request
Jan 18, 2024
* Added support for visionOS * Maintenance (#38) * Updated testable combine publishers * Fixed Swift 6 conflicting generic aliases warning * Fixed Xcode 14.3 UI test bug * Update CI macOS and Xcode versions * build destination corrections * tidy up ci devices * Fix flaky tests * Upgrade actions * Temporarily™ disabled broken UI tests * Bumpped CI to use Xcode 15.2. Also enabled unit tests for the VisionOS test target --------- Co-authored-by: Bill Dunay <wdunay@wayfair.com> Co-authored-by: Albert Bori <github@albertbori.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses some outstanding maintenance issues:
RenderedContainertype declared a generic alias ofState, however, its enclosing typeRenderedViewStatealready declared an alias ofState, and therefore these generic aliases were contradicting. Swift produced a warning about this issue that, "will be an error in Swift 6". The simple fix was to remove the redundant generic alias..switches.firstMatch.Type of Change
Checklist