epoll with fs fixes
#4050
Merged
epoll with fs fixes
#4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed first anyway
…un without the need for Tokio
Doesn't seem to be used anywhere, so it's removed...
Needed in some cases for customization of the root fs.
Remove code duplication by reusing code paths
Remove he webc_runner and webc_runner_rt_wasi features from the wasmer_wasix crate. These features do not require any additional dependencies, and just add complexity for no good reason. There was historical motivation for these features, because the wasmer::Engine did not support module compilation on all target architectures in the past, but now it is no longer neccessary.
Add Runtime::load_module / Runtime::load_module_sync methods that are responsible for loading (compiling + caching) Webassembly modules. This allows implementers to customize module compilation and caching, for example to prevent concurrent compilation of the same module.
… a bespoke one. The bespoke one is only needed for the Web Browser
|
wasi::python test is flaky as its dependent on external API calls (GraphQL) |
|
I fixed up the Wasmer Web build - next up the snapshot tests seem to still be failing |
…asmer into asynchronous-io-with-fs-fixes
…asmer into asynchronous-io-with-fs-fixes
ptitSeb
approved these changes
Jul 21, 2023
Closed
This was referenced Jul 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.