Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display human-friendly progress when starting wasmer run #3985

Merged
merged 7 commits into from
Jun 20, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

This fixes #3981 by adding some spinners during certain parts of the startup process.

I've mostly done this by creating a wrapper wasmer_wasix::Runtime implementation that will display progress bars during certain operations. Unfortunately, our current abstractions don't really expose the hooks we'd want for fine-grained progress updates like telling people how many bytes have been downloaded for a certain package, and some expensive operations (e.g. module compilation) aren't possible to hook into for reporting progress, but I guess it's better than nothing 🤷

@Michael-F-Bryan Michael-F-Bryan merged commit 95c4352 into master Jun 20, 2023
53 checks passed
@Michael-F-Bryan Michael-F-Bryan deleted the wasmer-run-output branch June 20, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The wasmer run command doesn't show any output when starting
2 participants