Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency serde_cbor is unmaintained #5041

Closed
webmaster128 opened this issue Aug 26, 2024 · 4 comments · Fixed by #5043
Closed

Dependency serde_cbor is unmaintained #5041

webmaster128 opened this issue Aug 26, 2024 · 4 comments · Fixed by #5043
Assignees

Comments

@webmaster128
Copy link
Contributor

webmaster128 commented Aug 26, 2024

When using Wasmer, wasmer-config pulls in the unmaintained dependency serde_cbor. Would be great if that could be removed from the codebase in favour of an actively maintained solution.

See https://rustsec.org/advisories/RUSTSEC-2021-0127

@syrusakbary
Copy link
Member

syrusakbary commented Aug 26, 2024

Thanks for the ping!
Right now the wasmer crate depends on wasmer-types which depends on webc which depends on wasmer-config. Thankfully, wasmer-config is not being used at all when using the wasmer create, so it should be trivial to remove (it's only used in the CLI or WASIX).

We shall remove the webc in wasmer-types, so it doesn't leak into the wasmer crate.

@syrusakbary
Copy link
Member

Also, webc should be using wasmer-config 0.5 as the rest (so the types doesn't become duplicated)

@webmaster128
Copy link
Contributor Author

We shall remove the webc in wasmer-types, so it doesn't leak into the wasmer crate.

This would indeed be great as I ran into dependency issues because of that a few weeks ago (don't remember anymore what it was exactly but something outdated)

@webmaster128
Copy link
Contributor Author

By the way, I was trying to find the repo for webc and could not find it. https://github.com/wasmerio/pirita does not seem to be public. Is that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants