Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wasmer crate without toml, serde_yaml and tar crates? #4886

Closed
dsherret opened this issue Jun 22, 2024 · 2 comments
Closed

Use wasmer crate without toml, serde_yaml and tar crates? #4886

dsherret opened this issue Jun 22, 2024 · 2 comments
Labels
priority-high High priority issue ❓ question I've a question!

Comments

@dsherret
Copy link
Contributor

Summary

Just a followup to #4750

I tried upgrading again, but:

  • the webc crate that wasmer-types depends on pulls in toml 0.7.8 and also wasmer-config which pulls in toml 0.8.14
  • webc also pulls in tar
  • wasmer-config pulls in serde_yaml

I kind of feel like all these dependencies should be unnecessary for just using the runtime?

@syrusakbary
Copy link
Member

Indeed, those libraries shouldn’t be needed

@syrusakbary syrusakbary added the priority-high High priority issue label Jun 27, 2024
@syrusakbary
Copy link
Member

This was caused by having a webc dependency in the wasmer-types as you mentioned.

This issue was also exposed in #5041 and fixed in #5043. The fix is now in main and will be live in the next release of Wasmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-high High priority issue ❓ question I've a question!
Projects
None yet
Development

No branches or pull requests

2 participants