Skip to content

Commit

Permalink
chore(wasix): Reduce syscall instrumentation levels
Browse files Browse the repository at this point in the history
Improve tracing performance by reducing the syscall instrumentation
levels to "trace".

This allows compiling out all the instrumentation with a tracing feature
flag in release builds.
  • Loading branch information
theduke committed Sep 20, 2024
1 parent 5627f94 commit f30c1d6
Show file tree
Hide file tree
Showing 80 changed files with 85 additions and 85 deletions.
6 changes: 3 additions & 3 deletions lib/wasix/src/syscalls/legacy/snapshot0.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use crate::{
};

/// Wrapper around `syscalls::fd_filestat_get` for old Snapshot0
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn fd_filestat_get(
mut ctx: FunctionEnvMut<WasiEnv>,
fd: Fd,
Expand All @@ -30,7 +30,7 @@ pub fn fd_filestat_get(
}

/// Wrapper around `syscalls::path_filestat_get` for old Snapshot0
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn path_filestat_get(
mut ctx: FunctionEnvMut<WasiEnv>,
fd: Fd,
Expand All @@ -50,7 +50,7 @@ pub fn path_filestat_get(

/// Wrapper around `syscalls::fd_seek` with extra logic to remap the values
/// of `Whence`
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn fd_seek(
ctx: FunctionEnvMut<WasiEnv>,
fd: Fd,
Expand Down
4 changes: 2 additions & 2 deletions lib/wasix/src/syscalls/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,7 @@ where
Ok(Errno::Success)
}

#[instrument(level = "debug", skip_all, fields(memory_stack_len = memory_stack.len(), rewind_stack_len = rewind_stack.len(), store_data_len = store_data.len()))]
// NOTE: not tracing-instrumented because [`rewind_ext`] already is.
#[must_use = "the action must be passed to the call loop"]
pub fn rewind<M: MemorySize, T>(
mut ctx: FunctionEnvMut<WasiEnv>,
Expand All @@ -1277,7 +1277,7 @@ where
)
}

#[instrument(level = "debug", skip_all, fields(rewind_stack_len = rewind_stack.len(), store_data_len = store_data.len()))]
#[instrument(level = "tracing", skip_all, fields(rewind_stack_len = rewind_stack.len(), store_data_len = store_data.len()))]
#[must_use = "the action must be passed to the call loop"]
pub fn rewind_ext<M: MemorySize>(
ctx: &mut FunctionEnvMut<WasiEnv>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/args_get.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::syscalls::*;
/// - `char *argv_buf`
/// A pointer to a buffer to write the argument string data.
///
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn args_get<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
argv: WasmPtr<WasmPtr<u8, M>, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/args_sizes_get.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::syscalls::*;
/// The number of arguments.
/// - `size_t *argv_buf_size`
/// The size of the argument string data.
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn args_sizes_get<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
argc: WasmPtr<M::Offset, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/environ_get.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::{journal::SnapshotTrigger, syscalls::*};
/// A pointer to a buffer to write the environment variable pointers.
/// - `char *environ_buf`
/// A pointer to a buffer to write the environment variable string data.
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn environ_get<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
environ: WasmPtr<WasmPtr<u8, M>, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_advise.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::syscalls::*;
/// The length from the offset to which the advice applies
/// - `__wasi_advice_t advice`
/// The advice to give
#[instrument(level = "debug", skip_all, fields(%fd, %offset, %len, ?advice), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, %offset, %len, ?advice), ret)]
pub fn fd_advise(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_allocate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::syscalls::*;
/// The offset from the start marking the beginning of the allocation
/// - `Filesize len`
/// The length from the offset marking the end of the allocation
#[instrument(level = "debug", skip_all, fields(%fd, %offset, %len), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, %offset, %len), ret)]
pub fn fd_allocate(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_close.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::syscalls::*;
/// If `fd` is a directory
/// - `Errno::Badf`
/// If `fd` is invalid or not open
#[instrument(level = "debug", skip_all, fields(pid = ctx.data().process.pid().raw(), %fd), ret)]
#[instrument(level = "trace", skip_all, fields(pid = ctx.data().process.pid().raw(), %fd), ret)]
pub fn fd_close(mut ctx: FunctionEnvMut<'_, WasiEnv>, fd: WasiFd) -> Result<Errno, WasiError> {
wasi_try_ok!(WasiEnv::process_signals_and_exit(&mut ctx)?);

Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_datasync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::syscalls::*;
/// Inputs:
/// - `Fd fd`
/// The file descriptor to sync
#[instrument(level = "debug", skip_all, fields(%fd), ret)]
#[instrument(level = "trace", skip_all, fields(%fd), ret)]
pub fn fd_datasync(mut ctx: FunctionEnvMut<'_, WasiEnv>, fd: WasiFd) -> Result<Errno, WasiError> {
wasi_try_ok!(WasiEnv::process_signals_and_exit(&mut ctx)?);

Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_dup.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::syscalls::*;
/// Outputs:
/// - `Fd fd`
/// The new file handle that is a duplicate of the original
#[instrument(level = "debug", skip_all, fields(%fd, ret_fd = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, ret_fd = field::Empty), ret)]
pub fn fd_dup<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::{fs::NotificationInner, syscalls::*};

/// ### `fd_event()`
/// Creates a file handle for event notifications
#[instrument(level = "debug", skip_all, fields(%initial_val, ret_fd = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%initial_val, ret_fd = field::Empty), ret)]
pub fn fd_event<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
initial_val: u64,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_fdstat_set_flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::syscalls::*;
/// The file descriptor to apply the new flags to
/// - `Fdflags flags`
/// The flags to apply to `fd`
#[instrument(level = "debug", skip_all, fields(%fd), ret)]
#[instrument(level = "trace", skip_all, fields(%fd), ret)]
pub fn fd_fdstat_set_flags(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_fdstat_set_rights.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::syscalls::*;
/// The rights to apply to `fd`
/// - `Rights fs_rights_inheriting`
/// The inheriting rights to apply to `fd`
#[instrument(level = "debug", skip_all, fields(%fd), ret)]
#[instrument(level = "trace", skip_all, fields(%fd), ret)]
pub fn fd_fdstat_set_rights(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
4 changes: 2 additions & 2 deletions lib/wasix/src/syscalls/wasi/fd_filestat_get.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::types::wasi::Snapshot0Filestat;
/// Output:
/// - `Filestat *buf`
/// Where the metadata from `fd` will be written
#[instrument(level = "debug", skip_all, fields(%fd), ret)]
#[instrument(level = "trace", skip_all, fields(%fd), ret)]
pub fn fd_filestat_get<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down Expand Up @@ -56,7 +56,7 @@ pub(crate) fn fd_filestat_get_internal(
/// Output:
/// - `Snapshot0Filestat *buf`
/// Where the metadata from `fd` will be written
#[instrument(level = "debug", skip_all, fields(%fd), ret)]
#[instrument(level = "trace", skip_all, fields(%fd), ret)]
pub fn fd_filestat_get_old<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_filestat_set_size.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::syscalls::*;
/// File descriptor to adjust
/// - `Filesize st_size`
/// New size that `fd` will be set to
#[instrument(level = "debug", skip_all, fields(%fd, %st_size), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, %st_size), ret)]
pub fn fd_filestat_set_size(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_filestat_set_times.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::syscalls::*;
/// Last modified time
/// - `Fstflags fst_flags`
/// Bit-vector for controlling which times get set
#[instrument(level = "debug", skip_all, fields(%fd, %st_atim, %st_mtim), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, %st_atim, %st_mtim), ret)]
pub fn fd_filestat_set_times(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_renumber.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::syscalls::*;
/// File descriptor to copy
/// - `Fd to`
/// Location to copy file descriptor to
#[instrument(level = "debug", skip_all, fields(%from, %to), ret)]
#[instrument(level = "trace", skip_all, fields(%from, %to), ret)]
pub fn fd_renumber(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
from: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_sync.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::syscalls::*;
/// TODO: figure out which errors this should return
/// - `Errno::Perm`
/// - `Errno::Notcapable`
#[instrument(level = "debug", skip_all, fields(%fd), ret)]
#[instrument(level = "trace", skip_all, fields(%fd), ret)]
pub fn fd_sync(mut ctx: FunctionEnvMut<'_, WasiEnv>, fd: WasiFd) -> Result<Errno, WasiError> {
wasi_try_ok!(WasiEnv::process_signals_and_exit(&mut ctx)?);

Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/fd_tell.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::syscalls::*;
/// Output:
/// - `Filesize *offset`
/// The offset of `fd` relative to the start of the file
#[instrument(level = "debug", skip_all, fields(%fd, offset = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, offset = field::Empty), ret)]
pub fn fd_tell<M: MemorySize>(
ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_filestat_set_times.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use crate::syscalls::*;
/// The timestamp that the last modified time attribute is set to
/// - `Fstflags fst_flags`
/// A bitmask controlling which attributes are set
#[instrument(level = "debug", skip_all, fields(%fd, path = field::Empty, %st_atim, %st_mtim), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, path = field::Empty, %st_atim, %st_mtim), ret)]
pub fn path_filestat_set_times<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use crate::syscalls::*;
/// String containing the new file path
/// - `u32 old_path_len`
/// Length of the `new_path` string
#[instrument(level = "debug", skip_all, fields(%old_fd, %new_fd, old_path = field::Empty, new_path = field::Empty, follow_symlinks = false), ret)]
#[instrument(level = "trace", skip_all, fields(%old_fd, %new_fd, old_path = field::Empty, new_path = field::Empty, follow_symlinks = false), ret)]
pub fn path_link<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
old_fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_open.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use crate::syscalls::*;
/// The new file descriptor
/// Possible Errors:
/// - `Errno::Access`, `Errno::Badf`, `Errno::Fault`, `Errno::Fbig?`, `Errno::Inval`, `Errno::Io`, `Errno::Loop`, `Errno::Mfile`, `Errno::Nametoolong?`, `Errno::Nfile`, `Errno::Noent`, `Errno::Notdir`, `Errno::Rofs`, and `Errno::Notcapable`
#[instrument(level = "debug", skip_all, fields(%dirfd, path = field::Empty, follow_symlinks = field::Empty, ret_fd = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%dirfd, path = field::Empty, follow_symlinks = field::Empty, ret_fd = field::Empty), ret)]
pub fn path_open<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
dirfd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_readlink.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use crate::syscalls::*;
/// Pointer to characters containing the path that the symlink points to
/// - `u32 buf_used`
/// The number of bytes written to `buf`
#[instrument(level = "debug", skip_all, fields(%dir_fd, path = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%dir_fd, path = field::Empty), ret)]
pub fn path_readlink<M: MemorySize>(
ctx: FunctionEnvMut<'_, WasiEnv>,
dir_fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_remove_directory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use super::*;
use crate::syscalls::*;

/// Returns Errno::Notemtpy if directory is not empty
#[instrument(level = "debug", skip_all, fields(%fd, path = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, path = field::Empty), ret)]
pub fn path_remove_directory<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_rename.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use crate::syscalls::*;
/// Pointer to UTF8 bytes, the new file name
/// - `u32 new_path_len`
/// The number of bytes to read from `new_path`
#[instrument(level = "debug", skip_all, fields(%old_fd, %new_fd, old_path = field::Empty, new_path = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%old_fd, %new_fd, old_path = field::Empty, new_path = field::Empty), ret)]
pub fn path_rename<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
old_fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_symlink.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use crate::syscalls::*;
/// Array of UTF-8 bytes representing the target path
/// - `u32 new_path_len`
/// The number of bytes to read from `new_path`
#[instrument(level = "debug", skip_all, fields(%fd, old_path = field::Empty, new_path = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, old_path = field::Empty, new_path = field::Empty), ret)]
pub fn path_symlink<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
old_path: WasmPtr<u8, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/path_unlink_file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::syscalls::*;
/// Array of UTF-8 bytes representing the path
/// - `u32 path_len`
/// The number of bytes in the `path` array
#[instrument(level = "debug", skip_all, fields(%fd, path = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(%fd, path = field::Empty), ret)]
pub fn path_unlink_file<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
fd: WasiFd,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/proc_exit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use crate::syscalls::*;
/// Inputs:
/// - `ExitCode`
/// Exit code to return to the operating system
#[instrument(level = "debug", skip_all)]
#[instrument(level = "trace", skip_all)]
pub fn proc_exit<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
code: ExitCode,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/proc_raise.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use crate::syscalls::*;
/// Inputs:
/// - `Signal`
/// Signal to be raised for this process
#[instrument(level = "debug", skip_all, fields(sig), ret)]
#[instrument(level = "trace", skip_all, fields(sig), ret)]
pub fn proc_raise(mut ctx: FunctionEnvMut<'_, WasiEnv>, sig: Signal) -> Result<Errno, WasiError> {
let env = ctx.data();
env.process.signal_process(sig);
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasi/thread_spawn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use wasmer_wasix_types::wasi::ThreadStart;
///
/// Returns the thread index of the newly created thread
/// (indices always start from the same value as `pid` and increments in steps)
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn thread_spawn<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
start_ptr: WasmPtr<ThreadStart<M>, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/chdir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::syscalls::*;

/// ### `chdir()`
/// Sets the current working directory
#[instrument(level = "debug", skip_all, fields(name = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(name = field::Empty), ret)]
pub fn chdir<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
path: WasmPtr<u8, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/getcwd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use crate::syscalls::*;
/// Returns the current working directory
/// If the path exceeds the size of the buffer then this function
/// will return ERANGE
#[instrument(level = "debug", skip_all, fields(path = field::Empty, max_path_len = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(path = field::Empty, max_path_len = field::Empty), ret)]
pub fn getcwd<M: MemorySize>(
ctx: FunctionEnvMut<'_, WasiEnv>,
path: WasmPtr<u8, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_addr_add.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::syscalls::*;
/// ## Parameters
///
/// * `addr` - Address to be added
#[instrument(level = "debug", skip_all, fields(ip = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(ip = field::Empty), ret)]
pub fn port_addr_add<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
ip: WasmPtr<__wasi_cidr_t, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_addr_clear.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::syscalls::*;

/// ### `port_addr_clear()`
/// Clears all the addresses on the local port
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn port_addr_clear(mut ctx: FunctionEnvMut<'_, WasiEnv>) -> Result<Errno, WasiError> {
wasi_try_ok!(port_addr_clear_internal(&mut ctx)?);

Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_addr_list.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use crate::syscalls::*;
/// ## Return
///
/// The number of addresses returned.
#[instrument(level = "debug", skip_all, fields(naddrs = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(naddrs = field::Empty), ret)]
pub fn port_addr_list<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
addrs_ptr: WasmPtr<__wasi_cidr_t, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_addr_remove.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use crate::syscalls::*;
/// ## Parameters
///
/// * `addr` - Address to be removed
#[instrument(level = "debug", skip_all, fields(ip = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(ip = field::Empty), ret)]
pub fn port_addr_remove<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
ip: WasmPtr<__wasi_addr_t, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_bridge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use crate::syscalls::*;
/// * `network` - Fully qualified identifier for the network
/// * `token` - Access token used to authenticate with the network
/// * `security` - Level of encryption to encapsulate the network connection with
#[instrument(level = "debug", skip_all, fields(network = field::Empty, ?security), ret)]
#[instrument(level = "trace", skip_all, fields(network = field::Empty, ?security), ret)]
pub fn port_bridge<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
network: WasmPtr<u8, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_dhcp_acquire.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::syscalls::*;

/// ### `port_dhcp_acquire()`
/// Acquires a set of IP addresses using DHCP
#[instrument(level = "debug", skip_all, ret)]
#[instrument(level = "trace", skip_all, ret)]
pub fn port_dhcp_acquire(mut ctx: FunctionEnvMut<'_, WasiEnv>) -> Result<Errno, WasiError> {
wasi_try_ok!(port_dhcp_acquire_internal(&mut ctx)?);

Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_gateway_set.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use crate::syscalls::*;
/// ## Parameters
///
/// * `addr` - Address of the default gateway
#[instrument(level = "debug", skip_all, fields(ip = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(ip = field::Empty), ret)]
pub fn port_gateway_set<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
ip: WasmPtr<__wasi_addr_t, M>,
Expand Down
2 changes: 1 addition & 1 deletion lib/wasix/src/syscalls/wasix/port_mac.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use crate::syscalls::*;

/// ### `port_mac()`
/// Returns the MAC address of the local port
#[instrument(level = "debug", skip_all, fields(max = field::Empty), ret)]
#[instrument(level = "trace", skip_all, fields(max = field::Empty), ret)]
pub fn port_mac<M: MemorySize>(
mut ctx: FunctionEnvMut<'_, WasiEnv>,
ret_mac: WasmPtr<__wasi_hardwareaddress_t, M>,
Expand Down
Loading

0 comments on commit f30c1d6

Please sign in to comment.