Skip to content

Commit

Permalink
Fixes for sockets (#4211)
Browse files Browse the repository at this point in the history
* Removed the unsafe code used by the selector

* Fixed some potential race conditions on the normal polling

* Removed a debug step that was added earlier

* Fixed a warning

* Implemented some polling methods for read_ready and write_ready

* Cleaned some leftover code

* Fixed the connectivity issues, these were as follows:
- When registering a handler twice it would fail the second time
- DONTROUTE was being set which basically breaks all networking
- Poll was registered on the wrong events (this was introduced in this patch earlier rather than from mainline)
- The writable event was being triggered at the wrong time (i.e. either too early or two late) - converted to a non-blocking poll call instead
- Added a unit test so that this doesn't happen again

* Updated lock file

* Updated lock file

* Went backwards on some dependencies which are causing issues with the compiler version

* - Added more methods to the interest handler for expanded functionality
- Fixed the windows build issues
- Fixed some linting errors
- Fixed some epoll backwards compatible issues
- Implemented a unit tests for epoll to google

* Linting error and windows build fixes

* Removed the static selector

* Updated the lock file

* Re-enabled socket option DONTROUTE, issue was in wasix-libc

* Added a missing check for waiting backlog

* Added fixes for the listeners which were erroring out incorrectly

* Added some extra error handling

---------

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
  • Loading branch information
john-sharratt and ptitSeb committed Sep 18, 2023
1 parent 47ad69c commit b3dde1a
Show file tree
Hide file tree
Showing 16 changed files with 1,327 additions and 503 deletions.
5 changes: 5 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,10 @@
"editor.formatOnSave": false,
"editor.formatOnPaste": false,
"editor.formatOnType": false
},
"[rust]": {
"editor.formatOnSave": true,
"editor.formatOnPaste": false,
"editor.formatOnType": false
}
}
94 changes: 47 additions & 47 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit b3dde1a

Please sign in to comment.