Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: octal rule triggers on time format #293

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

nicholasmhughes
Copy link
Contributor

Time values such as this:

some_calendar_entry:
  file.managed:
    - name: /tmp/my_unit_file
    - contents: |
        OnCalendar=Sun 18:00

should not trigger this rule.

Changed the regex to accommodate this case while still catching/ignoring previous identified test cases

@roaldnefs roaldnefs self-requested a review January 6, 2023 16:20
@roaldnefs
Copy link
Member

Thanks @nicholasmhughes for your contribution!

@roaldnefs roaldnefs merged commit cc6e617 into warpnet:main Jan 6, 2023
@nicholasmhughes nicholasmhughes deleted the fix-octal-rule-for-time branch January 6, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants