-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[210] [HIGH] Numbers that start with '0' should always be encapsulated in quotation marks - False positive in latest release 0.9.0 #299
Comments
Looks like it was this commit that caused the issue: |
I'm also seeing this in a yaml heredoc, as:
fake-scsi:
file.managed:
- name: /usr/local/scsi.txt
- user: root
- group: root
- mode: '0644'
- contents: |
[0:0:0:0] tape IBM ULTRIUM-HH8 MA71 /dev/st0 /dev/sg3
[0:0:0:1] mediumx QUANTUM UHDL 0096 /dev/sch0 /dev/sg4
[0:0:1:0] tape IBM ULTRIUM-HH6 KAJ9 /dev/st1 /dev/sg5
|
Hi all 👋🏻 ! Thanks for the reports. We are indeed experiencing this ourselves as well. I will discuss with @roaldnefs next week and, by the looks of things, most likely remove the rule and draft a new release. We apologise for the inconvenience caused by this. |
As reported in #299 Signed-off-by: Jeffrey Bouter <jeffrey.bouter@warpnet.nl>
Hi @nicholasmhughes - I'd like to inform you that your change has caused a lot of false-positives, and we will therefore be reverting it to resolve that issue. I'm aware that your change was a fix for another false-positive, which we will need to address in a future release. |
As reported in #299 Signed-off-by: Jeffrey Bouter <jeffrey.bouter@warpnet.nl>
Make sure all of these are captured in the test cases. Tests ran clean with my change. |
@nicholasmhughes Indeed, for the next test we will add the common false-positives. :-) |
This issue has been resolved in release v0.9.1 |
Describe the bug
I have the following state:
that was previously passing linting, but is now complaining about:
chmod 0640
even though the whole string is encapsulated in quotes:[210] [HIGH] Numbers that start with '0' should always be encapsulated in quotation marks
To Reproduce
Steps to reproduce the behavior:
2.Run salt-lint to lint it
Expected behavior
File to pass linting
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: