Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from ruby:master #357

Merged
merged 81 commits into from
Sep 10, 2023
Merged

[pull] master from ruby:master #357

merged 81 commits into from
Sep 10, 2023

Commits on Sep 6, 2023

  1. [ruby/openssl] Remove OSSL_DEBUG compile-time option

    Remove the OSSL_DEBUG flag and OpenSSL.mem_check_start which is only
    compiled when the flag is given. They are meant purely for development
    of Ruby/OpenSSL.
    
    OpenSSL.mem_check_start helped us find memory leak bugs in past, but
    it is no longer working with the recent OpenSSL versions. Let's just
    remove it now.
    
    ruby/openssl@8c7a6a17e2
    rhenium authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    912f1cd View commit details
    Browse the repository at this point in the history
  2. [ruby/openssl] Refactor Buffering consume_rbuff and getbyte methods

    Prefer ``slice!`` for ``Buffering#consume_rbuff`` and safe navigation with ``ord`` for ``Buffering#getbyte``, similar to ``each_byte``.
    
    ruby/openssl@5f6abff178
    Maumagnaguagno authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    4a042b2 View commit details
    Browse the repository at this point in the history
  3. [ruby/openssl] ssl: use ffdhe2048 from RFC 7919 as the default DH gro…

    …up parameters
    
    In TLS 1.2 or before, if DH group parameters for DHE are not supplied
    with SSLContext#tmp_dh= or #tmp_dh_callback=, we currently use the
    self-generated parameters added in commit ruby/openssl@bb3399a61c03 ("support 2048
    bit length DH-key", 2016-01-15) as the fallback.
    
    While there is no known weakness in the current parameters, it would be
    a good idea to switch to pre-defined, more well audited parameters.
    
    This also allows the fallback to work in the FIPS mode.
    
    The PEM encoding was derived with:
    
    	# RFC 7919 Appendix A.1. ffdhe2048
    	print OpenSSL::PKey.read(OpenSSL::ASN1::Sequence([OpenSSL::ASN1::Integer((<<-END).split.join.to_i(16)), OpenSSL::ASN1::Integer(2)]).to_der).to_pem
    	    FFFFFFFF FFFFFFFF ADF85458 A2BB4A9A AFDC5620 273D3CF1
    	    D8B9C583 CE2D3695 A9E13641 146433FB CC939DCE 249B3EF9
    	    7D2FE363 630C75D8 F681B202 AEC4617A D3DF1ED5 D5FD6561
    	    2433F51F 5F066ED0 85636555 3DED1AF3 B557135E 7F57C935
    	    984F0C70 E0E68B77 E2A689DA F3EFE872 1DF158A1 36ADE735
    	    30ACCA4F 483A797A BC0AB182 B324FB61 D108A94B B2C8E3FB
    	    B96ADAB7 60D7F468 1D4F42A3 DE394DF4 AE56EDE7 6372BB19
    	    0B07A7C8 EE0A6D70 9E02FCE1 CDF7E2EC C03404CD 28342F61
    	    9172FE9C E98583FF 8E4F1232 EEF28183 C3FE3B1B 4C6FAD73
    	    3BB5FCBC 2EC22005 C58EF183 7D1683B2 C6F34A26 C1B2EFFA
    	    886B4238 61285C97 FFFFFFFF FFFFFFFF
    	END
    
    ruby/openssl@a5527cb4f4
    rhenium authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b6d7cdc View commit details
    Browse the repository at this point in the history
  4. [ruby/openssl] Prefer String#unpack1

    (ruby/openssl#586)
    
    String#unpack1 avoids the intermediate array created by String#unpack
    for single elements, while also making a call to Array#first/[0]
    unnecessary.
    
    ruby/openssl@8eb0715a42
    Maumagnaguagno authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    60a6de8 View commit details
    Browse the repository at this point in the history
  5. [ruby/openssl] Fix OCSP documentation

    `port` should be called on the `ocsp_uri` URI instead of `ocsp`, which
    is just a string.
    
    ruby/openssl@89a1c82dd0
    p8 authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    9b6128c View commit details
    Browse the repository at this point in the history
  6. [ruby/openssl] x509ext: test OpenSSL::X509::ExtensionFactory#create_e…

    …xt with ln
    
    OpenSSL::X509::ExtensionFactory#create_ext and #create_extensions
    accepts both sn (short names) and ln (long names) for registered OIDs.
    
    This is different from the behavior of the openssl command-line utility
    which accepts only sn in openssl.cnf keys.
    
    Add a test case to check this.
    
    ruby/openssl@91ae46c8d7
    rhenium authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    98d8f61 View commit details
    Browse the repository at this point in the history
  7. [ruby/openssl] x509ext: let X509::ExtensionFactory#create_ext take a …

    …dotted OID string
    
    instead of looking of NIDs and then using X509V3_EXT_nconf_nid,
    instead just pass strings to X509V3_EXT_nconf, which has all the logic for
    processing dealing with generic extensions
    also process the oid through ln2nid() to retain compatibility.
    
    [rhe: tweaked commit message and added a test case]
    
    ruby/openssl@9f15741331
    mcr authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    91e5f51 View commit details
    Browse the repository at this point in the history
  8. [ruby/openssl] test/openssl/test_ossl.rb: relax assertion for error m…

    …essages
    
    The test case test_error_data utilizes the error message generated by
    X509V3_EXT_nconf_nid(). The next commit will use X509V3_EXT_nconf(),
    which generates a slightly different error message. Let's adapt the
    check to it.
    
    ruby/openssl@9cdfa3a4d1
    rhenium authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    1d4a43e View commit details
    Browse the repository at this point in the history
  9. [ruby/openssl] test/openssl/test_pkey_ec.rb: refactor tests for EC.bu…

    …iltin_curves
    
    Check that OpenSSL::PKey::EC.builtin_curves returns an array in the
    expected format.
    
    Similarly to OpenSSL::Cipher.ciphers, OpenSSL::PKey::EC.builtin_curves
    returns a list of known named curves rather than actually usable ones.
    
    ruby/openssl#671 found that the list may
    include unapproved (and thus unusable) curves when the FIPS module is
    loaded.
    
    ruby/openssl@c53cbabe00
    rhenium authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    3fd90c0 View commit details
    Browse the repository at this point in the history
  10. Use the test-unit-ruby-core gem for Test::Unit::CoreAssertions

    test/lib/core_assertions.rb and its dependencies are now packaged in
    the gem test-unit-ruby-core. Let's use it instead.
    rhenium authored and hsbt committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    5ba480e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6356f6d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6408da7 View commit details
    Browse the repository at this point in the history
  13. Support freeing the lowest memory address page

    This should help fix the following flaky test:
    
    ```
      1) Failure:
    TestProcess#test_warmup_frees_pages [test/ruby/test_process.rb:2751]:
    <0> expected but was
    <1>.
    ```
    peterzhu2118 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    6778d2c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4c9a036 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    dae6a0a View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5537169 View commit details
    Browse the repository at this point in the history
  17. [YARP] Use constant_id lookups where possible (#8374)

    This commit extracts a `yp_constant_id_lookup` method and uses yp_constant_id_lookup where possible
    jemmaissroff committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ae41bda View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a52ac35 View commit details
    Browse the repository at this point in the history
  19. Fix missing write barrier in iseq instruction list

    There's a missing write barrier for operands in the iseq instruction
    list, which can cause crashes.
    
    It can be reproduced when Ruby is compiled with `-DRUBY_DEBUG_ENV=1`.
    Using the following command:
    
    ```
    RUBY_GC_HEAP_OLDOBJECT_LIMIT_FACTOR=0 RUBY_DEBUG=gc_stress ruby -w --disable=gems -Itool/lib -W0 test.rb
    ```
    
    The following script crashes:
    
    ```
    require "test/unit"
    ```
    peterzhu2118 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    b3b57f7 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    1d4d9a0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    dee383b View commit details
    Browse the repository at this point in the history
  22. YJIT: Make compiled_* stats available by default (#8379)

    * YJIT: Make compiled_* stats available by default
    
    * Update comment about default counters [ci skip]
    
    Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
    
    ---------
    
    Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
    k0kubun and maximecb committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a334077 View commit details
    Browse the repository at this point in the history
  23. Try to fix flaky test_warmup_frees_pages

    This test sometimes fails with:
    
    ```
      1) Failure:
    TestProcess#test_warmup_frees_pages [test/ruby/test_process.rb:2750]:
    <202> expected but was
    <203>.
    ```
    peterzhu2118 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    08929b3 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    746eede View commit details
    Browse the repository at this point in the history
  25. Fix crash in WeakMap during compaction

    WeakMap can crash during compaction because the st_insert could allocate
    memory.
    peterzhu2118 committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    12102d1 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    fdf7aad View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    f1422e4 View commit details
    Browse the repository at this point in the history
  28. [ruby/yarp] Consider source encoding for slice

    ruby/prism@8f59fc27cd
    
    Co-authored-by: Kevin Newton <kddnewton@users.noreply.github.com>
    2 people authored and matzbot committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    acd626a View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    54274b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    af1bedb View commit details
    Browse the repository at this point in the history
  2. [rubygems/rubygems] Improve efficiency of Index#use and #search_all

    Rename Index#use(override = true) to #merge!
    
    Rename Index @all_specs to @Duplicates, it is not actually all specs.
    @Duplicates only holds specs that would have been overridden during a call to
    Index#use or Index#merge!
    
    Reduced dupes in @Duplicates by not double adding the new spec to the
    index and the @Duplicates during #merge!
    
    Reduce Array creation by using specialized methods when the one result
    or no results are needed from the search.
    
    rubygems/rubygems@47e91125db
    martinemde authored and matzbot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    86b93f7 View commit details
    Browse the repository at this point in the history
  3. [rubygems/rubygems] Reduce excess index creation and merging

    When @allow_cached is true, @allow_local is always true,
    therefore, the #installed_specs will always be merged after #cached_specs
    is called. This makes starting with installed_specs.dup redundant.
    
    When #cached_specs is called because @allow_remote is true and
    @allow_cached is false, then installed_specs will be added after
    cached_specs based on @allow_local.
    
    We never need to add installed_specs here, so don't.
    
    rubygems/rubygems@49b38f9750
    martinemde authored and matzbot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    89cb956 View commit details
    Browse the repository at this point in the history
  4. [DOC] Fix up Process::Status#>>

    nobu committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ac65fc8 View commit details
    Browse the repository at this point in the history
  5. Reduce number of iterations in TestFiberScheduler#test_autoload. (#…

    …8391)
    
    `ppc64le` appears to be struggling with this test due to timeout. Let's see
    if reducing the number of iterations can help improve the test performance.
    ioquatix committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    05aaff2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bd04676 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    009e0a3 View commit details
    Browse the repository at this point in the history
  8. Extract do_mutex_lock_check_interrupts to try and fix ppc64le. (#…

    …8393)
    
    We found some tests were hanging in `do_mutex_lock`, specifically the
    fiber scheduler autoload test. After much investigation, it may be a code
    generation bug. Because we didn't change the code, but only extracted it
    into a separate function, and it appears to fix the problem.
    ioquatix committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    5184b40 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e2a0f25 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9e21b33 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3f78eec View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9343ef2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    14970cf View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0c89287 View commit details
    Browse the repository at this point in the history
  15. Remove function call for String#bytesize (#8389)

    * Remove function call for String#bytesize
    
    String size is stored in a consistent location, so we can eliminate the
    function call.
    
    * Update yjit/src/codegen.rs
    
    Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
    
    ---------
    
    Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com>
    Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
    3 people committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    0adca62 View commit details
    Browse the repository at this point in the history
  16. [ruby/yarp] Introduce owned constants

    Before this commit, constants in the constant pool were assumed to
    be slices of the source string. This works in _almost_ all cases.
    
    There are times, however, when a string needs to be synthesized.
    This can occur when passing in locals that need to be scoped through
    eval, or when generating method names like `foo=`.
    
    After this commit, there is a single bit `owned` boolean on
    constants in the pool that indicates whether or not it is a slice
    of the source string. If it is not, it is assumed to be allocated
    memory that should be freed by the constant pool when the constant
    pool is freed.
    
    When serializing, the most significant bit in the location of the
    contents of the constant indicates whether or not it is owned.
    When it is, instead of 4 bytes for the source offset and 4 bytes
    for the length it is instead 4 bytes for the buffer offset and 4
    bytes the length. The contents of the owned constants are embedded
    into the buffer after the constant pool itself.
    
    ruby/prism@461c047365
    kddnewton authored and matzbot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    194584f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    44b52c5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    630e490 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    7adc38b View commit details
    Browse the repository at this point in the history
  20. Document that thread event hooks are called without the GVL

    Except for the `RESUMED` event.
    byroot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2d37b44 View commit details
    Browse the repository at this point in the history
  21. [ruby/yarp] Extract error messages into diagnostic.c and use canonica…

    …l message IDs
    
    The parser now passes around `yp_diagnostic_id_t` for diagnostic
    messages instead of character strings, and we rely on the function
    `diagnostic_message()` to resolve that to a string.
    
    In addition, many messages were edited so that the parser expresses
    coordinate ideas in similar form [1] using consistent voice and
    typographic conventions.
    
    Closes ruby/prism#1379, and makes progress on #941.
    
      [1] Strunk & White rule 19
    
    ruby/prism@0b6dd85bf1
    flavorjones authored and matzbot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    4efcaf9 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5b5ae3d View commit details
    Browse the repository at this point in the history
  23. [ruby/yarp] Avoid an extra "stop" parameter to yp_strspn_whitespace_n…

    …ewlines
    
    and use yp_strspn_inline_whitespace instead.
    
    Partially reverts implementation details from #1152
    
    ruby/prism@c8f9f4cfde
    flavorjones authored and matzbot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    60a52ca View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    fcdedf7 View commit details
    Browse the repository at this point in the history
  25. Skip allocation if handle_interrupt arg is already usable

    If the supplied hash is already frozen and compare-by-identity, we can
    use it directly (still checking its contents are valid symbols), without
    making a new copy.
    matthewd authored and jhawthorn committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ed712e0 View commit details
    Browse the repository at this point in the history
  26. Optimize handle_interrupt(Exception => ..) as a common case

    When interrupt behavior is configured for all possible exceptions using
    'Exception', there's no need to iterate the pending exception's
    ancestors for hash lookups.
    
    More significantly, by storing the catch-all timing symbol directly in
    the mask stack, we can skip allocating the hash we would otherwise need.
    matthewd authored and jhawthorn committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    aed5215 View commit details
    Browse the repository at this point in the history
  27. GC: Only force alloc slowpath for NEWOBJ hook

    Previously, configuring any GC event hook would cause all allocations to
    go through the newobj slowpath. We should only need to do that when the
    newobj specifically is subscribed to.
    
    This renames flags.has_hook to flags.has_newobj_hook, to make this new
    usage clear. newobj_of0 was the only place which previously checked this
    flag.
    jhawthorn committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    094f336 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    89edce4 View commit details
    Browse the repository at this point in the history
  2. Add String#getbyte YJIT implementation (#8397)

    * Add getbyte JIT implementation
    
    Adds an implementation for String#getbyte for YJIT, along with a
    bootstrap test. This should be helpful for pure Ruby implementations
    and to avoid unneeded allocations.
    
    Co-authored-by: John Hawthorn <jhawthorn@github.com>
    
    * Skip the getbyte test for RJIT for now
    
    ---------
    
    Co-authored-by: John Hawthorn <jhawthorn@github.com>
    Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
    3 people committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    78233e8 View commit details
    Browse the repository at this point in the history
  3. Continue even if addr or rnglists headers not found

    Fix up commit 31d1226, "Avoid aborting inside addr2line.c".
    Source code informations did not appear in C level backtrace since
    that change.
    nobu committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b6df6f9 View commit details
    Browse the repository at this point in the history
  4. Bump actions/cache from 3.3.1 to 3.3.2

    Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2.
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@88522ab...704facf)
    
    ---
    updated-dependencies:
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and matzbot committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    15fd897 View commit details
    Browse the repository at this point in the history
  5. Try default gcc 9.4.0 to see if it exhibits the same compiler bugs. (

    …#8394)
    
    * Revert "Extract `do_mutex_lock_check_interrupts` to try and fix `ppc64le`. (#8393)"
    
    This reverts commit 5184b40.
    
    * .travis.yml: Try default gcc 9.4.0 instead of gcc-10 in ppc64le and s390x.
    
    Use gcc 9.4.0 instead of gcc-10 to avoid the current failures by a possible GCC
    10 compiler bug in the Travis ppc64le and s390x cases. And it also aligns with
    RubyCI Ubuntu ppc64le and s390x where the default gcc is used.
    
    ---------
    
    Co-authored-by: Jun Aruga <jaruga@ruby-lang.org>
    ioquatix and junaruga committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    be21a05 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f39b576 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c7d6118 View commit details
    Browse the repository at this point in the history
  8. [YARP] Implement compilation for InterpolatedXStringNode (#8395)

    * [YARP] Implemented compilation for InterpolatedXStringNode
    
    * Extract common function for interpolated nodes
    jemmaissroff committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8807b0d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    af5df9e View commit details
    Browse the repository at this point in the history
  10. [DOC] Kernel#{proc,lambda} don't issue warnings anymore

    They've been raising since 3.0.0.
    XrXr committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    60ef156 View commit details
    Browse the repository at this point in the history
  11. Fix weak_references count test

    This test creates a lot of Objects held in an array, and a set of weak
    references to them using WeakMap. It then clears the array and frees it
    and asserts that all the weak references to it are also gone.
    
    This test is failing because one of the dummy objects in our weakmap is
    ending up on the stack, and so is being marked, even though we thought
    that we'd removed the only reference to it.
    
    This behaviour has changed since this commit:
    
    5b5ae3d
    
    which rewrites `Integer#times` from C into Ruby. This change is somehow
    causing the last object we append to our array to consistently end up on
    the stack during GC.
    
    This commit fixes the specific weakmap test by using an enumerator and
    each, instead of `Integer#times`, and thus avoids having our last object
    created end up on the stack.
    eightbitraptor committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    7f53da9 View commit details
    Browse the repository at this point in the history
  12. [ruby/yarp] Add ParseResult#attach_comments! to tie comments to their…

    … locations
    
    ruby/prism@ddc699156f
    
    Co-authored-by: Kevin Newton <kddnewton@users.noreply.github.com>
    2 people authored and matzbot committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6050b5a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7fc4db3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    5d73c0f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c0f162c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f4443f3 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1f35789 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    d9ede18 View commit details
    Browse the repository at this point in the history
  19. memory_view: Avoid using bit field

    Bit field's memory layout is implementation-defined.
    
    See also:
    https://wiki.sei.cmu.edu/confluence/display/c/EXP11-C.+Do+not+make+assumptions+regarding+the+layout+of+structures+with+bit-fields
    
    If memory layout is implementation-defined, it's difficult to use from
    FFI library such as Ruby-FFI.
    kou committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    90dad2b View commit details
    Browse the repository at this point in the history
  20. [DOC] Update Reline and IRB's maintainers list (#8406)

    Update Reline and IRB's maintainers list
    
    Maintainers' order follows the same order they appear in the projects'
    contributors list as of the time this commit is made.
    st0012 committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b635a66 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Configuration menu
    Copy the full SHA
    f2102e4 View commit details
    Browse the repository at this point in the history
  2. [DOC] Fix a typo in "Open Options" section of IO

    The word "and" was missing.
    herwinw committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    b926ac5 View commit details
    Browse the repository at this point in the history
  3. [DOC] Fix method docs of scheduler#io_read and scheduler#io_write

    Each of Fiber::Scheduler#io_read and io_write takes the "offset" as the fourth argument, which is not doucmented.
    kudojp authored and nobu committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0e49f81 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b5914a7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    16882d4 View commit details
    Browse the repository at this point in the history