[pull] master from ruby:master #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://github.com/avatars/in/12910?s=60&v=4){kind=small}
… YAML class references does not warn Before this, you would get constant redefinition warnings on Psych::DefaultKey Additionally, ensure the retries wont continue infinitely in the case of the ArgumentError not being caused by Marshal trying to load the undefined classes rubygems/rubygems@919e8c2de4
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
…it to avoid allocating another hash. `String#start_with?` is faster than regex that is bound to the start of a string. rubygems/rubygems@9b2006ef09
…Array. that means we can use bang methods to avoid allocating new copies rubygems/rubygems@8bc13fa55f
…multiple times. This saves allocating 2 arrays rubygems/rubygems@48c03b33b7
…. The individual keys are also new, so we can use ! methods on each individual one as well. rubygems/rubygems@f2e912b9bb
…d allocating it multiple times rubygems/rubygems@8eac49c429
…locating a matchdata, which is not used rubygems/rubygems@cbf9ac93d7
…ng. Use .prepend to avoid allocating a new string. rubygems/rubygems@2ac35a661f
…? would still include that rubygems/rubygems@235d9b38d8
(ruby/reline#580) Timeout's implementation relies on Thread, which would conflict with `ruby/debug`'s thread-freezing implementation and has casued issues like - ruby/debug#877 - ruby/debug#934 - ruby/debug#1000 This commit avoids the issue by completely removing the use of Timeout. ruby/reline@d4f0cd3fe1
(ruby/irb#686) * Support `VISUAL` env var, and prefer it over `EDITOR` * Update test/irb/test_cmd.rb --------- ruby/irb@399b872c31 Co-authored-by: Stan Lo <stan001212@gmail.com>
* For example in ProgramNode: # attr_reader statements: Node => # attr_reader statements: StatementsNode ruby/prism@ffed35238c
Previously, parsing a snippet like this:
%r\nfoo\n
would result in tracking the second newline twice, resulting in a
failed runtime assertion.
Fixing that issue reveals another bug, which is that the _first_
newline was not being tracked at all. So we introduce a call to
yp_newline_list right when we construct the REGEXP_BEGIN token.
ruby/prism@0d5d759091
…r, fix newlines on __END__ ruby/prism@9da0bc4452
…ntain write nodes It makes it more difficult to find all locations where a variable is written to if they're just read nodes. To keep things consistent we should make them write nodes. ruby/prism@840e094045
Previously, parsing a snippet like this:
%r\nfoo\n
would result in tracking the second newline twice, resulting in a
failed runtime assertion.
Fixing that issue reveals another bug, which is that the _first_
newline was not being tracked at all. So we introduce a call to
yp_newline_list right when we construct the REGEXP_BEGIN token.
ruby/prism@0d5d759091
YARP commits were synced out of order. We are doing this reset commit to ensure that all files are currently correct and we can proceed with monitoring syncs so this doesn't happen again.
integration (ruby/irb#688) * Avoid overriding user's irb_name setting in debugger integration Instead of always setting `irb_name` to `irb:rdbg`, it should respect the user's setting and only append `:rdbg` to it. * Introduce write_rc test helper ruby/irb@2ce7593351
Previously this failed an assertion and aborted. ruby/prism@a037d942a8
(rubygems/rubygems#6898) Supports .tool-versions (ASDF) by checking for a line starting with "ruby" before falling back to reading the entire file, as in .ruby-version. rubygems/rubygems@6c0a3e793a
(ruby/erb#49) I was surprised to see erb show up when I was using memory_profiler on my app. ERB::Compiler#compile has a blank string literal, and it ended up allocating some 41532 blank strings for a relatively small surface area. ruby/erb@b7e45c2bdc
It doesn't use optparse, so the location is not flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )